blimp/client/session/assignment_source.cc - Issue 1676023002: Make IPAddress::FromIPLiteral a member function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/session/assignment_source.cc

Issue 1676023002: Make IPAddress::FromIPLiteral a member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/session/assignment_source.cc

diff --git a/blimp/client/session/assignment_source.cc b/blimp/client/session/assignment_source.cc

index 271569cb04b2916017a905b2910cfb6dbb55ec35..a83c66f4ac1b7ec63fb5883b679806d269677a3b 100644

--- a/blimp/client/session/assignment_source.cc

+++ b/blimp/client/session/assignment_source.cc

@@ -31,7 +31,7 @@ net::IPAddress GetBlimpletIPAddress() {

host = kDefaultBlimpletIPAddress;

}

net::IPAddress ip_address;

- if (!net::IPAddress::FromIPLiteral(host, &ip_address))

+ if (!ip_address.AssignFromIPLiteral(host))

CHECK(false) << "Invalid BlimpletAssignment host " << host;

return ip_address;

}