Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1645503002: Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't pin… (Closed)

Created:
4 years, 11 months ago by vasilii
Modified:
4 years, 11 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't ping the model after bubble destruction. Rename some classes for good. BUG=579726 Committed: https://crrev.com/234fc4fc3226b78e67e25ef254da5a870ff99563 Cr-Commit-Position: refs/heads/master@{#371781}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -157 lines) Patch
M chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.h View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm View 3 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/auto_signin_view_controller.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/auto_signin_view_controller.mm View 1 chunk +16 lines, -18 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.h View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.mm View 5 chunks +20 lines, -22 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller_unittest.mm View 2 chunks +21 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.h View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.mm View 5 chunks +22 lines, -24 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller_unittest.mm View 6 chunks +25 lines, -15 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/password_prompt_view_bridge.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/password_prompt_view_bridge.mm View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm View 2 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/passwords_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/pending_password_view_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
vasilii
Hi Vaclav, please review.
4 years, 11 months ago (2016-01-27 13:08:43 UTC) #3
vabr (Chromium)
lgtm
4 years, 11 months ago (2016-01-27 13:13:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645503002/1
4 years, 11 months ago (2016-01-27 13:32:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 13:37:45 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 13:38:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/234fc4fc3226b78e67e25ef254da5a870ff99563
Cr-Commit-Position: refs/heads/master@{#371781}

Powered by Google App Engine
This is Rietveld 408576698