Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Side by Side Diff: chrome/browser/ui/cocoa/passwords/base_passwords_controller_test.h

Issue 1645503002: Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't pin… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_PASSWORDS_BASE_PASSWORDS_CONTROLLER_TEST_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_PASSWORDS_BASE_PASSWORDS_CONTROLLER_TEST_H_
6 #define CHROME_BROWSER_UI_COCOA_PASSWORDS_BASE_PASSWORDS_CONTROLLER_TEST_H_ 6 #define CHROME_BROWSER_UI_COCOA_PASSWORDS_BASE_PASSWORDS_CONTROLLER_TEST_H_
7 7
8 #include "chrome/browser/ui/cocoa/cocoa_profile_test.h" 8 #include "chrome/browser/ui/cocoa/cocoa_profile_test.h"
9 #include "chrome/browser/ui/cocoa/cocoa_test_helper.h" 9 #include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
10 #import "chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controlle r.h" 10 #import "chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controlle r.h"
(...skipping 25 matching lines...) Expand all
36 // ManagePasswordsBubbleModel. 36 // ManagePasswordsBubbleModel.
37 virtual ManagePasswordsBubbleModel::DisplayReason GetDisplayReason() const; 37 virtual ManagePasswordsBubbleModel::DisplayReason GetDisplayReason() const;
38 38
39 private: 39 private:
40 ManagePasswordsUIControllerMock* ui_controller_; 40 ManagePasswordsUIControllerMock* ui_controller_;
41 scoped_ptr<content::WebContents> test_web_contents_; 41 scoped_ptr<content::WebContents> test_web_contents_;
42 scoped_ptr<ManagePasswordsBubbleModel> model_; 42 scoped_ptr<ManagePasswordsBubbleModel> model_;
43 }; 43 };
44 44
45 // Helper delegate for testing the views of the password management bubble. 45 // Helper delegate for testing the views of the password management bubble.
46 @interface ContentViewDelegateMock 46 @interface ContentViewDelegateMock : NSObject<BasePasswordsContentViewDelegate>
47 : NSObject<ManagePasswordsBubbleContentViewDelegate>
48 @property(nonatomic) ManagePasswordsBubbleModel* model; 47 @property(nonatomic) ManagePasswordsBubbleModel* model;
49 @property(readonly, nonatomic) BOOL dismissed; 48 @property(readonly, nonatomic) BOOL dismissed;
50 @end 49 @end
51 50
52 #endif // CHROME_BROWSER_UI_COCOA_PASSWORDS_BASE_PASSWORDS_CONTROLLER_TEST_H_ 51 #endif // CHROME_BROWSER_UI_COCOA_PASSWORDS_BASE_PASSWORDS_CONTROLLER_TEST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698