chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm - Issue 1645503002: Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't pin…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm

Issue 1645503002: Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't pin… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/pending_password_view_controller.h ('k') | chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm b/chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm

index 97a838e6b3fae5abf8573b19f2c0dc6f64ffc164..5bab804e5d4f4ec0f085ccb1d7f6bcb694c946f8 100644

--- a/chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm

@@ -28,7 +28,7 @@ const SkColor kWarmWelcomeColor = SkColorSetRGB(0x64, 0x64, 0x64);

ManagePasswordsBubbleModel* model = [self model];

if (model)

model->OnBrandLinkClicked();

- [delegate_ viewShouldDismiss];

+ [self.delegate viewShouldDismiss];

return YES;

}

@@ -38,7 +38,7 @@ const SkColor kWarmWelcomeColor = SkColorSetRGB(0x64, 0x64, 0x64);

base::scoped_nsobject<NSButton> button(

[[WebUIHoverCloseButton alloc] initWithFrame:frame]);

[button setAction:@selector(viewShouldDismiss)];

- [button setTarget:delegate_];

+ [button setTarget:self.delegate];

return button;

}

@@ -172,7 +172,7 @@ const SkColor kWarmWelcomeColor = SkColorSetRGB(0x64, 0x64, 0x64);

}

- (ManagePasswordsBubbleModel*)model {

- return [delegate_ model];

+ return [self.delegate model];

}

@end