Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3433)

Unified Diff: chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.h

Issue 1645503002: Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't pin… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.h
diff --git a/chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.h b/chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.h
index 6fadc63943222e353457f7c2addde7a37af7ad34..0f9b5b268d15d13c965108ff44e14d682abda017 100644
--- a/chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.h
+++ b/chrome/browser/ui/cocoa/passwords/confirmation_password_saved_view_controller.h
@@ -11,21 +11,17 @@
#import "chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.h"
@class HyperlinkTextView;
-class ManagePasswordsBubbleModel;
// Manages the view that confirms that the generated password was saved.
-@interface ManagePasswordsBubbleConfirmationViewController
- : ManagePasswordsBubbleContentViewController<NSTextViewDelegate> {
+@interface ConfirmationPasswordSavedViewController
+ : BasePasswordsContentViewController<NSTextViewDelegate> {
@private
- ManagePasswordsBubbleModel* model_; // weak
base::scoped_nsobject<HyperlinkTextView> confirmationText_;
base::scoped_nsobject<NSButton> okButton_;
}
-- (id)initWithModel:(ManagePasswordsBubbleModel*)model
- delegate:(id<ManagePasswordsBubbleContentViewDelegate>)delegate;
@end
-@interface ManagePasswordsBubbleConfirmationViewController (Testing)
+@interface ConfirmationPasswordSavedViewController (Testing)
@property(readonly) HyperlinkTextView* confirmationText;
@property(readonly) NSButton* okButton;
@end

Powered by Google App Engine
This is Rietveld 408576698