chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller.mm - Issue 1645503002: Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't pin…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller.mm

Issue 1645503002: Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't pin… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller.mm b/chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller.mm

index 186e38a66bdc9eb5f459b360554fcd02225638b6..40a451004138cd79a44b7de2b824a9fd78396000 100644

--- a/chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/update_pending_password_view_controller.mm

@@ -32,14 +32,14 @@

model->OnUpdateClicked(model->pending_password());

}

- [delegate_ viewShouldDismiss];

+ [self.delegate viewShouldDismiss];

}

- (void)onNopeClicked:(id)sender {

ManagePasswordsBubbleModel* model = [self model];

if (model)

model->OnNopeUpdateClicked();

- [delegate_ viewShouldDismiss];

+ [self.delegate viewShouldDismiss];

}

- (NSView*)createPasswordView {

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm ('k') | no next file » | no next file with comments »