Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3530)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/passwords/password_prompt_view_bridge.mm

Issue 1645503002: Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't pin… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/passwords/password_prompt_view_bridge.h ('k') | chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/passwords/password_prompt_view_bridge.mm
diff --git a/chrome/browser/ui/cocoa/passwords/password_prompt_view_bridge.mm b/chrome/browser/ui/cocoa/passwords/password_prompt_view_bridge.mm
index f0380b28811a256837727592ba80b28e8ad407dc..ee393c081e393fe1154855f3bc76c420fef27dab 100644
--- a/chrome/browser/ui/cocoa/passwords/password_prompt_view_bridge.mm
+++ b/chrome/browser/ui/cocoa/passwords/password_prompt_view_bridge.mm
@@ -18,7 +18,9 @@ PasswordPromptViewBridge::PasswordPromptViewBridge(
web_contents_(web_contents) {
}
-PasswordPromptViewBridge::~PasswordPromptViewBridge() = default;
+PasswordPromptViewBridge::~PasswordPromptViewBridge() {
+ [view_controller_ setBridge:nil];
+}
void PasswordPromptViewBridge::Show() {
view_controller_.reset(
« no previous file with comments | « chrome/browser/ui/cocoa/passwords/password_prompt_view_bridge.h ('k') | chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698