Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4907)

Unified Diff: chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.h

Issue 1645503002: Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't pin… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.h
diff --git a/chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.h b/chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.h
index 839d7c438a918959216dec0ac73f38fe479d9140..5cefe8f7644efed919d3ad585275960426ecdac3 100644
--- a/chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.h
+++ b/chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.h
@@ -10,7 +10,7 @@
class ManagePasswordsBubbleModel;
// Handles user interaction with the content view.
-@protocol ManagePasswordsBubbleContentViewDelegate<NSObject>
+@protocol BasePasswordsContentViewDelegate<NSObject>
// The user performed an action that should dismiss the bubble.
- (void)viewShouldDismiss;
@@ -21,10 +21,11 @@ class ManagePasswordsBubbleModel;
@end
// Base class for a state of the password management bubble.
-@interface ManagePasswordsBubbleContentViewController : NSViewController {
- id<ManagePasswordsBubbleContentViewDelegate> delegate_; // Weak.
+@interface BasePasswordsContentViewController : NSViewController {
+ @private
+ id<BasePasswordsContentViewDelegate> delegate_; // Weak.
}
-- (id)initWithDelegate:(id<ManagePasswordsBubbleContentViewDelegate>)delegate;
+- (instancetype)initWithDelegate:(id<BasePasswordsContentViewDelegate>)delegate;
- (NSButton*)addButton:(NSString*)title
toView:(NSView*)view
target:(id)target
@@ -36,8 +37,7 @@ class ManagePasswordsBubbleModel;
// Returns the default button for the bubble.
- (NSButton*)defaultButton;
-@property(nonatomic, assign)
- id<ManagePasswordsBubbleContentViewDelegate> delegate;
+@property(nonatomic, assign) id<BasePasswordsContentViewDelegate> delegate;
@end

Powered by Google App Engine
This is Rietveld 408576698