Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Side by Side Diff: chrome/browser/ui/cocoa/passwords/pending_password_view_controller.h

Issue 1645503002: Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't pin… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_PASSWORDS_PENDING_PASSWORD_VIEW_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_PASSWORDS_PENDING_PASSWORD_VIEW_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_COCOA_PASSWORDS_PENDING_PASSWORD_VIEW_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_COCOA_PASSWORDS_PENDING_PASSWORD_VIEW_CONTROLLER_H_
7 7
8 #import <Cocoa/Cocoa.h> 8 #import <Cocoa/Cocoa.h>
9 9
10 #include "base/mac/scoped_nsobject.h" 10 #include "base/mac/scoped_nsobject.h"
11 #import "chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controlle r.h" 11 #import "chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controlle r.h"
12 12
13 @class PasswordsListViewController; 13 @class PasswordsListViewController;
14 14
15 // Base class for the views that offer to save/update the user's password. 15 // Base class for the views that offer to save/update the user's password.
16 @interface PendingPasswordViewController 16 @interface PendingPasswordViewController
17 : ManagePasswordsBubbleContentViewController<NSTextViewDelegate> { 17 : BasePasswordsContentViewController<NSTextViewDelegate> {
18 @private 18 @private
19 base::scoped_nsobject<NSButton> closeButton_; 19 base::scoped_nsobject<NSButton> closeButton_;
20 } 20 }
21 21
22 // Creates a controller for showing username/password and returns its view. 22 // Creates a controller for showing username/password and returns its view.
23 - (NSView*)createPasswordView; 23 - (NSView*)createPasswordView;
24 24
25 // Returns whether GoogleSmartLock warm welcome should be shown. 25 // Returns whether GoogleSmartLock warm welcome should be shown.
26 - (BOOL)shouldShowGoogleSmartLockWelcome; 26 - (BOOL)shouldShowGoogleSmartLockWelcome;
27 27
28 // Creates buttons that should be shown in the bubble and returns them. 28 // Creates buttons that should be shown in the bubble and returns them.
29 - (NSArray*)createButtonsAndAddThemToView:(NSView*)view; 29 - (NSArray*)createButtonsAndAddThemToView:(NSView*)view;
30 30
31 @property(readonly) ManagePasswordsBubbleModel* model; 31 @property(readonly) ManagePasswordsBubbleModel* model;
32 @end 32 @end
33 33
34 @interface PendingPasswordViewController (Testing) 34 @interface PendingPasswordViewController (Testing)
35 @property(readonly) NSButton* closeButton; 35 @property(readonly) NSButton* closeButton;
36 @end 36 @end
37 37
38 #endif // CHROME_BROWSER_UI_COCOA_PASSWORDS_PENDING_PASSWORD_VIEW_CONTROLLER_H_ 38 #endif // CHROME_BROWSER_UI_COCOA_PASSWORDS_PENDING_PASSWORD_VIEW_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698