Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.h

Issue 1645503002: Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't pin… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.h
diff --git a/chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.h b/chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.h
index edcee8a3948f4b9928b4c55c2f276884c378fd3f..e6438995d683e41b1fdb9887a71d4bd886259b0d 100644
--- a/chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.h
+++ b/chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.h
@@ -10,7 +10,6 @@
#include "base/mac/scoped_nsobject.h"
#import "chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controller.h"
-class ManagePasswordsBubbleModel;
@class PasswordsListViewController;
// Informs the user that no passwords are stored for the current site.
@@ -19,20 +18,16 @@ class ManagePasswordsBubbleModel;
@end
// Manages the view that allows users to manage passwords for a site.
-@interface ManagePasswordsBubbleManageViewController
- : ManagePasswordsBubbleContentViewController {
+@interface ManagePasswordsViewController : BasePasswordsContentViewController {
@private
- ManagePasswordsBubbleModel* model_; // weak
base::scoped_nsobject<NSButton> doneButton_;
base::scoped_nsobject<NSButton> manageButton_;
base::scoped_nsobject<NoPasswordsView> noPasswordsView_;
base::scoped_nsobject<PasswordsListViewController> passwordsListController_;
}
-- (id)initWithModel:(ManagePasswordsBubbleModel*)model
- delegate:(id<ManagePasswordsBubbleContentViewDelegate>)delegate;
@end
-@interface ManagePasswordsBubbleManageViewController (Testing)
+@interface ManagePasswordsViewController (Testing)
@property(readonly) NSButton* doneButton;
@property(readonly) NSButton* manageButton;
@property(readonly) NoPasswordsView* noPasswordsView;

Powered by Google App Engine
This is Rietveld 408576698