Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm

Issue 1645503002: Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't pin… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm
diff --git a/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm b/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm
index d6df328d5639db6b84eeccd5f14be1511163e7ea..b9139d271ce16be4d3c7e7a38f6f4128bbb3624f 100644
--- a/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm
+++ b/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm
@@ -68,20 +68,14 @@
currentController_.reset([[UpdatePendingPasswordViewController alloc]
initWithDelegate:self]);
} else if (model_->state() == password_manager::ui::CONFIRMATION_STATE) {
- currentController_.reset(
- [[ManagePasswordsBubbleConfirmationViewController alloc]
- initWithModel:model_
- delegate:self]);
+ currentController_.reset([[ConfirmationPasswordSavedViewController alloc]
+ initWithDelegate:self]);
} else if (model_->state() == password_manager::ui::MANAGE_STATE) {
currentController_.reset(
- [[ManagePasswordsBubbleManageViewController alloc]
- initWithModel:model_
- delegate:self]);
+ [[ManagePasswordsViewController alloc] initWithDelegate:self]);
} else if (model_->state() == password_manager::ui::AUTO_SIGNIN_STATE) {
currentController_.reset(
- [[ManagePasswordsBubbleAutoSigninViewController alloc]
- initWithModel:model_
- delegate:self]);
+ [[AutoSigninViewController alloc] initWithDelegate:self]);
} else {
NOTREACHED();
}
@@ -142,7 +136,7 @@
animate:[window isVisible]];
}
-#pragma mark ManagePasswordsBubbleContentViewDelegate
+#pragma mark BasePasswordsContentViewDelegate
- (void)viewShouldDismiss {
[self close];

Powered by Google App Engine
This is Rietveld 408576698