Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.h

Issue 1645503002: Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't pin… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_PASSWORDS_PASSWORDS_BUBBLE_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_PASSWORDS_PASSWORDS_BUBBLE_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_COCOA_PASSWORDS_PASSWORDS_BUBBLE_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_COCOA_PASSWORDS_PASSWORDS_BUBBLE_CONTROLLER_H_
7 7
8 #import <Cocoa/Cocoa.h> 8 #import <Cocoa/Cocoa.h>
9 9
10 #include "base/mac/scoped_nsobject.h" 10 #include "base/mac/scoped_nsobject.h"
11 #import "chrome/browser/ui/cocoa/base_bubble_controller.h" 11 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"
12 #import "chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controlle r.h" 12 #import "chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controlle r.h"
13 #import "chrome/browser/ui/cocoa/passwords/pending_password_view_controller.h" 13 #import "chrome/browser/ui/cocoa/passwords/pending_password_view_controller.h"
14 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h" 14 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
15 15
16 // Controller for the Cocoa manage passwords bubble. Transitions through several 16 // Controller for the Cocoa manage passwords bubble. Transitions through several
17 // views according to user interaction and updates the password management state 17 // views according to user interaction and updates the password management state
18 // accordingly. 18 // accordingly.
19 @interface ManagePasswordsBubbleController 19 @interface ManagePasswordsBubbleController
20 : BaseBubbleController<ManagePasswordsBubbleContentViewDelegate> { 20 : BaseBubbleController<BasePasswordsContentViewDelegate> {
21 @private 21 @private
22 ManagePasswordsBubbleModel* model_; 22 ManagePasswordsBubbleModel* model_;
23 base::scoped_nsobject<ManagePasswordsBubbleContentViewController> 23 base::scoped_nsobject<BasePasswordsContentViewController> currentController_;
24 currentController_;
25 } 24 }
26 - (id)initWithParentWindow:(NSWindow*)parentWindow 25 - (id)initWithParentWindow:(NSWindow*)parentWindow
27 model:(ManagePasswordsBubbleModel*)model; 26 model:(ManagePasswordsBubbleModel*)model;
28 @end 27 @end
29 28
30 @interface ManagePasswordsBubbleController (Testing) 29 @interface ManagePasswordsBubbleController (Testing)
31 @property(readonly) NSViewController* currentController; 30 @property(readonly) NSViewController* currentController;
32 @end 31 @end
33 32
34 #endif // CHROME_BROWSER_UI_COCOA_PASSWORDS_PASSWORDS_BUBBLE_CONTROLLER_H_ 33 #endif // CHROME_BROWSER_UI_COCOA_PASSWORDS_PASSWORDS_BUBBLE_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698