Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_view_controller.h

Issue 1645503002: Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't pin… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_PASSWORDS_MANAGE_PASSWORDS_VIEW_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_PASSWORDS_MANAGE_PASSWORDS_VIEW_CONTROLLER_H_
6 #define CHROME_BROWSER_UI_COCOA_PASSWORDS_MANAGE_PASSWORDS_VIEW_CONTROLLER_H_ 6 #define CHROME_BROWSER_UI_COCOA_PASSWORDS_MANAGE_PASSWORDS_VIEW_CONTROLLER_H_
7 7
8 #import <Cocoa/Cocoa.h> 8 #import <Cocoa/Cocoa.h>
9 9
10 #include "base/mac/scoped_nsobject.h" 10 #include "base/mac/scoped_nsobject.h"
11 #import "chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controlle r.h" 11 #import "chrome/browser/ui/cocoa/passwords/base_passwords_content_view_controlle r.h"
12 12
13 class ManagePasswordsBubbleModel;
14 @class PasswordsListViewController; 13 @class PasswordsListViewController;
15 14
16 // Informs the user that no passwords are stored for the current site. 15 // Informs the user that no passwords are stored for the current site.
17 @interface NoPasswordsView : NSTextField 16 @interface NoPasswordsView : NSTextField
18 - (id)initWithWidth:(CGFloat)width; 17 - (id)initWithWidth:(CGFloat)width;
19 @end 18 @end
20 19
21 // Manages the view that allows users to manage passwords for a site. 20 // Manages the view that allows users to manage passwords for a site.
22 @interface ManagePasswordsBubbleManageViewController 21 @interface ManagePasswordsViewController : BasePasswordsContentViewController {
23 : ManagePasswordsBubbleContentViewController {
24 @private 22 @private
25 ManagePasswordsBubbleModel* model_; // weak
26 base::scoped_nsobject<NSButton> doneButton_; 23 base::scoped_nsobject<NSButton> doneButton_;
27 base::scoped_nsobject<NSButton> manageButton_; 24 base::scoped_nsobject<NSButton> manageButton_;
28 base::scoped_nsobject<NoPasswordsView> noPasswordsView_; 25 base::scoped_nsobject<NoPasswordsView> noPasswordsView_;
29 base::scoped_nsobject<PasswordsListViewController> passwordsListController_; 26 base::scoped_nsobject<PasswordsListViewController> passwordsListController_;
30 } 27 }
31 - (id)initWithModel:(ManagePasswordsBubbleModel*)model
32 delegate:(id<ManagePasswordsBubbleContentViewDelegate>)delegate;
33 @end 28 @end
34 29
35 @interface ManagePasswordsBubbleManageViewController (Testing) 30 @interface ManagePasswordsViewController (Testing)
36 @property(readonly) NSButton* doneButton; 31 @property(readonly) NSButton* doneButton;
37 @property(readonly) NSButton* manageButton; 32 @property(readonly) NSButton* manageButton;
38 @property(readonly) NoPasswordsView* noPasswordsView; 33 @property(readonly) NoPasswordsView* noPasswordsView;
39 @property(readonly) PasswordsListViewController* passwordsListController; 34 @property(readonly) PasswordsListViewController* passwordsListController;
40 @end 35 @end
41 36
42 #endif // CHROME_BROWSER_UI_COCOA_PASSWORDS_MANAGE_PASSWORDS_VIEW_CONTROLLER_H_ 37 #endif // CHROME_BROWSER_UI_COCOA_PASSWORDS_MANAGE_PASSWORDS_VIEW_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698