Remove dangling ManagePasswordsBubbleModel pointers. Test that different password bubbles don't pin…

chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #import "chrome/browser/ui/cocoa/passwords/pending_password_view_controller.h"
 
 #include "base/mac/foundation_util.h"
 #include "base/strings/sys_string_conversions.h"
@@ skipping 10 matching lines @@
 const SkColor kWarmWelcomeColor = SkColorSetRGB(0x64, 0x64, 0x64);
 
 @implementation PendingPasswordViewController
 
 - (BOOL)textView:(NSTextView*)textView
     clickedOnLink:(id)link
           atIndex:(NSUInteger)charIndex {
   ManagePasswordsBubbleModel* model = [self model];
   if (model)
     model->OnBrandLinkClicked();
-  [delegate_ viewShouldDismiss];
+  [self.delegate viewShouldDismiss];
   return YES;
 }
 
 - (base::scoped_nsobject<NSButton>)newCloseButton {
   const int dimension = chrome_style::GetCloseButtonSize();
   NSRect frame = NSMakeRect(0, 0, dimension, dimension);
   base::scoped_nsobject<NSButton> button(
       [[WebUIHoverCloseButton alloc] initWithFrame:frame]);
   [button setAction:@selector(viewShouldDismiss)];
-  [button setTarget:delegate_];
+  [button setTarget:self.delegate];
   return button;
 }
 
 - (NSView*)createPasswordView {
   // Empty implementation, it should be implemented in child class.
   NOTREACHED();
   return nil;
 }
 
 - (BOOL)shouldShowGoogleSmartLockWelcome {
@@ skipping 113 matching lines @@
   [closeButton_ setFrameOrigin:closeButtonOrigin];
 
   // Update the bubble size.
 
   [view setFrame:NSMakeRect(0, 0, width, height)];
 
   [self setView:view];
 }
 
 - (ManagePasswordsBubbleModel*)model {
-  return [delegate_ model];
+  return [self.delegate model];
 }
 
 @end
 
 @implementation PendingPasswordViewController (Testing)
 
 - (NSButton*)closeButton {
   return closeButton_.get();
 }
 
 @end