DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions.

DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions.

Committed: https://crrev.com/edec985ebd1523623e10b5ae76b94697e2989f54
Cr-Commit-Position: refs/heads/master@{#364458}

[pfeldman, 2015-12-10 00:41:13]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2015-12-10 00:55:12]

lgtm

https://codereview.chromium.org/1514523004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.h (right):

https://codereview.chromium.org/1514523004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.h:9: #include
"core/inspector/v8/V8Debugger.h"
Unnecessary includes.

https://codereview.chromium.org/1514523004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.h:14:
v8::Local<v8::Object> compileDebuggerScript(v8::Isolate*);
Perhaps, rename this to DebuggerScript.h?

https://codereview.chromium.org/1514523004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h (right):

https://codereview.chromium.org/1514523004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h:144:
SkipPauseRequest didPause(v8::Local<v8::Context>, v8::Local<v8::Object>
callFrames, v8::Local<v8::Value> exception, const Vector<String>&
hitBreakpoints, bool isPromiseRejection);
Let's annotate with something like this:
// Interface for V8DebuggerImpl.

https://codereview.chromium.org/1514523004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerScript.h (right):

https://codereview.chromium.org/1514523004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerScript.h:94: enum
CompileResult { CompileSuccess, CompileError };
Using boolean here would be easier.

[pfeldman, 2015-12-10 01:14:45]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-12-10 01:14:45]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1514523004/#ps20001
(title: "review comments addressed.")

[commit-bot: I haz the power, 2015-12-10 01:16:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514523004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514523004/20001

[commit-bot: I haz the power, 2015-12-10 06:00:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-10 06:00:41]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[pfeldman, 2015-12-10 18:59:34]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2015-12-10 19:04:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514523004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514523004/20001

[commit-bot: I haz the power, 2015-12-10 20:27:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-10 20:28:21]

Description was changed from

==========
DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions.
==========

to

==========
DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions.

Committed: https://crrev.com/edec985ebd1523623e10b5ae76b94697e2989f54
Cr-Commit-Position: refs/heads/master@{#364458}
==========

[commit-bot: I haz the power, 2015-12-10 20:28:23]

Patchset 2 (id:??) landed as
https://crrev.com/edec985ebd1523623e10b5ae76b94697e2989f54
Cr-Commit-Position: refs/heads/master@{#364458}