Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h

Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
diff --git a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
index f567f44867b822037f71878f2215f7ac5f365ac8..e47dff70ace2fc366c378b98c4c5dc0af270b1ce 100644
--- a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
+++ b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h
@@ -31,7 +31,8 @@
#ifndef WorkerThreadDebugger_h
#define WorkerThreadDebugger_h
-#include "core/inspector/ScriptDebuggerBase.h"
+#include "core/inspector/v8/V8Debugger.h"
+#include "core/inspector/v8/V8DebuggerClient.h"
#include "wtf/Forward.h"
#include <v8.h>
@@ -40,7 +41,7 @@ namespace blink {
class WorkerThread;
-class WorkerThreadDebugger final : public ScriptDebuggerBase {
+class WorkerThreadDebugger final : public V8DebuggerClient {
WTF_MAKE_NONCOPYABLE(WorkerThreadDebugger);
public:
explicit WorkerThreadDebugger(WorkerThread*);
@@ -49,10 +50,16 @@ public:
static void setContextDebugData(v8::Local<v8::Context>);
static int contextGroupId();
+ V8Debugger* debugger() const { return m_debugger.get(); }
+
+ // V8DebuggerClient implementation.
+ v8::Local<v8::Object> compileDebuggerScript() override;
void runMessageLoopOnPause(int contextGroupId) override;
void quitMessageLoopOnPause() override;
private:
+ v8::Isolate* m_isolate;
+ OwnPtr<V8Debugger> m_debugger;
WorkerThread* m_workerThread;
bool m_paused;
};

Powered by Google App Engine
This is Rietveld 408576698