third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp - Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp

Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h ('k') | third_party/WebKit/Source/core/inspector/MainThreadDebugger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp

index 96a5263a2bbbf9da369d1431f6cbfa9ae867c72f..80fe949a73862d84cd103fc9d2e6787f75036a11 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.cpp

@@ -163,9 +163,9 @@ void InspectorRuntimeAgent::disable(ErrorString* errorString)

m_v8RuntimeAgent->disable(errorString);

}

-void InspectorRuntimeAgent::addExecutionContextToFrontend(int executionContextId, const String& type, const String& origin, const String& humanReadableName, const String& frameId)

+void InspectorRuntimeAgent::reportExecutionContextCreated(int executionContextId, const String& type, const String& origin, const String& humanReadableName, const String& frameId)

{

- m_v8RuntimeAgent->addExecutionContextToFrontend(executionContextId, type, origin, humanReadableName, frameId);

+ m_v8RuntimeAgent->reportExecutionContextCreated(executionContextId, type, origin, humanReadableName, frameId);

}

} // namespace blink