third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp - Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp

Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp ('k') | third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp b/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp

index 4e8e7892284e4497cee3f1680decbbd2b96dd7c1..c17872abbd0b004b74b8ee9e76678889eeda3909 100644

--- a/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp

@@ -172,7 +172,7 @@ void PageRuntimeAgent::reportExecutionContext(ScriptState* scriptState, bool isP

DOMWrapperWorld& world = scriptState->world();

String humanReadableName = world.isIsolatedWorld() ? world.isolatedWorldHumanReadableName() : "";

String type = isPageContext ? "" : "Extension";

- InspectorRuntimeAgent::addExecutionContextToFrontend(executionContextId, type, origin, humanReadableName, frameId);

+ InspectorRuntimeAgent::reportExecutionContextCreated(executionContextId, type, origin, humanReadableName, frameId);

}

} // namespace blink