third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp - Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp

Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp ('k') | third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2011 Google Inc. All rights reserved.	2 * Copyright (C) 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 154 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
165 }	165 }

166 }	166 }

167	167

168 void PageRuntimeAgent::reportExecutionContext(ScriptState* scriptState, bool isP ageContext, const String& origin, const String& frameId)	168 void PageRuntimeAgent::reportExecutionContext(ScriptState* scriptState, bool isP ageContext, const String& origin, const String& frameId)

169 {	169 {

170 int executionContextId = injectedScriptManager()->injectedScriptIdFor(script State);	170 int executionContextId = injectedScriptManager()->injectedScriptIdFor(script State);

171 m_scriptStateToId.set(scriptState, executionContextId);	171 m_scriptStateToId.set(scriptState, executionContextId);

172 DOMWrapperWorld& world = scriptState->world();	172 DOMWrapperWorld& world = scriptState->world();

173 String humanReadableName = world.isIsolatedWorld() ? world.isolatedWorldHuma nReadableName() : "";	173 String humanReadableName = world.isIsolatedWorld() ? world.isolatedWorldHuma nReadableName() : "";

174 String type = isPageContext ? "" : "Extension";	174 String type = isPageContext ? "" : "Extension";

175 InspectorRuntimeAgent::addExecutionContextToFrontend(executionContextId, typ e, origin, humanReadableName, frameId);	175 InspectorRuntimeAgent::reportExecutionContextCreated(executionContextId, typ e, origin, humanReadableName, frameId);

176 }	176 }

177	177

178 } // namespace blink	178 } // namespace blink

OLD	NEW