Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
diff --git a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
index 3381fcf5e27dfdbbbcae626a9a10a58243438123..09b46bda630c46331f17dd80d0fe20a75f5e4215 100644
--- a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
+++ b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
@@ -32,6 +32,7 @@
#include "core/inspector/WorkerThreadDebugger.h"
#include "bindings/core/v8/V8ScriptRunner.h"
+#include "core/inspector/DebuggerScript.h"
#include "core/inspector/WorkerDebuggerAgent.h"
#include "core/workers/WorkerThread.h"
#include <v8.h>
@@ -41,7 +42,8 @@ namespace blink {
static const int workerContextGroupId = 1;
WorkerThreadDebugger::WorkerThreadDebugger(WorkerThread* workerThread)
- : ScriptDebuggerBase(v8::Isolate::GetCurrent())
+ : m_isolate(v8::Isolate::GetCurrent())
+ , m_debugger(V8Debugger::create(v8::Isolate::GetCurrent(), this))
, m_workerThread(workerThread)
, m_paused(false)
{
@@ -61,6 +63,11 @@ int WorkerThreadDebugger::contextGroupId()
return workerContextGroupId;
}
+v8::Local<v8::Object> WorkerThreadDebugger::compileDebuggerScript()
+{
+ return blink::compileDebuggerScript(m_isolate);
+}
+
void WorkerThreadDebugger::runMessageLoopOnPause(int contextGroupId)
{
ASSERT(contextGroupId == workerContextGroupId);

Powered by Google App Engine
This is Rietveld 408576698