Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: third_party/WebKit/Source/core/inspector/DebuggerScript.cpp

Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/DebuggerScript.cpp
diff --git a/third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.cpp b/third_party/WebKit/Source/core/inspector/DebuggerScript.cpp
similarity index 54%
rename from third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.cpp
rename to third_party/WebKit/Source/core/inspector/DebuggerScript.cpp
index 3140cdcb2ae234390977370a492741a0fc5c0d5c..06e82cb7a51a321f9816c3c495050a17f55ef511 100644
--- a/third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.cpp
+++ b/third_party/WebKit/Source/core/inspector/DebuggerScript.cpp
@@ -3,7 +3,7 @@
// found in the LICENSE file.
#include "config.h"
-#include "core/inspector/ScriptDebuggerBase.h"
+#include "core/inspector/DebuggerScript.h"
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8ScriptRunner.h"
@@ -12,22 +12,12 @@
namespace blink {
-ScriptDebuggerBase::ScriptDebuggerBase(v8::Isolate* isolate)
- : m_isolate(isolate)
- , m_debugger(V8Debugger::create(isolate, this))
-{
-}
-
-ScriptDebuggerBase::~ScriptDebuggerBase()
-{
-}
-
-v8::Local<v8::Object> ScriptDebuggerBase::compileDebuggerScript()
+v8::Local<v8::Object> compileDebuggerScript(v8::Isolate* isolate)
{
const WebData& debuggerScriptSourceResource = Platform::current()->loadResource("DebuggerScriptSource.js");
- v8::Local<v8::String> source = v8String(m_isolate, String(debuggerScriptSourceResource.data(), debuggerScriptSourceResource.size()));
+ v8::Local<v8::String> source = v8String(isolate, String(debuggerScriptSourceResource.data(), debuggerScriptSourceResource.size()));
v8::Local<v8::Value> value;
- if (!V8ScriptRunner::compileAndRunInternalScript(source, m_isolate).ToLocal(&value))
+ if (!V8ScriptRunner::compileAndRunInternalScript(source, isolate).ToLocal(&value))
return v8::Local<v8::Object>();
ASSERT(value->IsObject());
return value.As<v8::Object>();

Powered by Google App Engine
This is Rietveld 408576698