third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp - Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp

Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp

diff --git a/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp b/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp

index b7594870253b4b6ae109d92ba83a222ba635ff4a..7863c9a566a241e04d8a5e9b858abfb789973de7 100644

--- a/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp

+++ b/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp

@@ -206,7 +206,7 @@ void V8RuntimeAgentImpl::disable(ErrorString* errorString)

{

}

-void V8RuntimeAgentImpl::addExecutionContextToFrontend(int executionContextId, const String& type, const String& origin, const String& humanReadableName, const String& frameId)

+void V8RuntimeAgentImpl::reportExecutionContextCreated(int executionContextId, const String& type, const String& origin, const String& humanReadableName, const String& frameId)

{

RefPtr<ExecutionContextDescription> description = ExecutionContextDescription::create()

.setId(executionContextId)

« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h ('k') | no next file » | no next file with comments »