Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
index 51c8ae820135dc7eac4e705f641c1d996795138e..8f609398a0f2e01f1986c23042d281f79c86df36 100644
--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
@@ -33,7 +33,7 @@
#include "core/CoreExport.h"
#include "core/inspector/InspectorTaskRunner.h"
-#include "core/inspector/ScriptDebuggerBase.h"
+#include "core/inspector/v8/V8DebuggerClient.h"
#include "platform/heap/Handle.h"
#include <v8.h>
@@ -44,8 +44,9 @@ class Mutex;
namespace blink {
class LocalFrame;
+class V8Debugger;
-class CORE_EXPORT MainThreadDebugger final : public ScriptDebuggerBase {
+class CORE_EXPORT MainThreadDebugger final : public V8DebuggerClient {
WTF_MAKE_NONCOPYABLE(MainThreadDebugger);
public:
class ClientMessageLoop {
@@ -69,15 +70,20 @@ public:
static MainThreadDebugger* instance();
static void interruptMainThreadAndRun(PassOwnPtr<InspectorTaskRunner::Task>);
InspectorTaskRunner* taskRunner() const { return m_taskRunner.get(); }
+ V8Debugger* debugger() const { return m_debugger.get(); }
private:
MainThreadDebugger(PassOwnPtr<ClientMessageLoop>, v8::Isolate*);
+ // V8DebuggerClient implementation.
+ v8::Local<v8::Object> compileDebuggerScript() override;
void runMessageLoopOnPause(int contextGroupId) override;
void quitMessageLoopOnPause() override;
static WTF::Mutex& creationMutex();
+ v8::Isolate* m_isolate;
+ OwnPtr<V8Debugger> m_debugger;
OwnPtr<ClientMessageLoop> m_clientMessageLoop;
OwnPtr<InspectorTaskRunner> m_taskRunner;

Powered by Google App Engine
This is Rietveld 408576698