Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h

Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
index 74c1506fd86ae8a3a90a6f61be94f3b137ad8bca..75a9f2738a8439f2daa98a140a902b9ac67f070a 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h
@@ -31,7 +31,6 @@
#include "bindings/core/v8/V8HiddenValue.h"
#include "bindings/core/v8/WrapperTypeInfo.h"
#include "core/CoreExport.h"
-#include "core/inspector/ScriptDebuggerBase.h"
#include "gin/public/isolate_holder.h"
#include "gin/public/v8_idle_task_runner.h"
#include "wtf/HashMap.h"
@@ -43,6 +42,7 @@
namespace blink {
class DOMDataStore;
+class MainThreadDebugger;
class StringCache;
class V8Debugger;
struct WrapperTypeInfo;
@@ -123,7 +123,7 @@ public:
void runEndOfScopeTasks();
void clearEndOfScopeTasks();
- void setScriptDebugger(PassOwnPtr<ScriptDebuggerBase>);
+ void setScriptDebugger(PassOwnPtr<MainThreadDebugger>);
private:
V8PerIsolateData();
@@ -158,7 +158,7 @@ private:
bool m_performingMicrotaskCheckpoint;
Vector<OwnPtr<EndOfScopeTask>> m_endOfScopeTasks;
- OwnPtr<ScriptDebuggerBase> m_scriptDebugger;
+ OwnPtr<MainThreadDebugger> m_scriptDebugger;
};
} // namespace blink
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698