third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h - Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h

Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgent.h ('k') | third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h

diff --git a/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h b/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h

index ad07144296e484545bc269ed96a85288111cc6e1..e19c3508ca28db21d6bb5e2138f835804a453572 100644

--- a/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h

+++ b/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h

@@ -93,7 +93,7 @@ public:

private:

InjectedScriptManager* injectedScriptManager() { return m_injectedScriptManager; }

- void addExecutionContextToFrontend(int executionContextId, const String& type, const String& origin, const String& humanReadableName, const String& frameId) override;

+ void reportExecutionContextCreated(int executionContextId, const String& type, const String& origin, const String& humanReadableName, const String& frameId) override;

RawPtrWillBeWeakPersistent<InspectorState> m_state;

InspectorFrontend::Runtime* m_frontend;