Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp

Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
index 94df9f465c3290db3748b2b2c40e2642d22d3c6e..058da7403485f293df3ccfbbb6181bec4d1cc11c 100644
--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
@@ -33,7 +33,9 @@
#include "bindings/core/v8/DOMWrapperWorld.h"
#include "core/frame/LocalFrame.h"
+#include "core/inspector/DebuggerScript.h"
#include "core/inspector/InspectorTaskRunner.h"
+#include "core/inspector/v8/V8Debugger.h"
#include "platform/UserGestureIndicator.h"
#include "wtf/OwnPtr.h"
#include "wtf/PassOwnPtr.h"
@@ -56,7 +58,8 @@ int frameId(LocalFrame* frame)
MainThreadDebugger* MainThreadDebugger::s_instance = nullptr;
MainThreadDebugger::MainThreadDebugger(PassOwnPtr<ClientMessageLoop> clientMessageLoop, v8::Isolate* isolate)
- : ScriptDebuggerBase(isolate)
+ : m_isolate(isolate)
+ , m_debugger(V8Debugger::create(isolate, this))
, m_clientMessageLoop(clientMessageLoop)
, m_taskRunner(adoptPtr(new InspectorTaskRunner(isolate)))
{
@@ -103,6 +106,11 @@ void MainThreadDebugger::interruptMainThreadAndRun(PassOwnPtr<InspectorTaskRunne
s_instance->m_taskRunner->interruptAndRun(task);
}
+v8::Local<v8::Object> MainThreadDebugger::compileDebuggerScript()
+{
+ return blink::compileDebuggerScript(m_isolate);
+}
+
void MainThreadDebugger::runMessageLoopOnPause(int contextGroupId)
{
LocalFrame* pausedFrame = WeakIdentifierMap<LocalFrame>::lookup(contextGroupId);

Powered by Google App Engine
This is Rietveld 408576698