third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgent.h - Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgent.h

Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/v8/V8DebuggerScript.cpp ('k') | third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgent.h b/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgent.h

index 5e880d700b86efe87931c0df700ac3fd7f846c7c..a342d821a7e62d171718f0708ef26c487c7ab22e 100644

--- a/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgent.h

+++ b/third_party/WebKit/Source/core/inspector/v8/V8RuntimeAgent.h

@@ -64,7 +64,7 @@ public:

virtual void setCustomObjectFormatterEnabled(ErrorString*, bool) = 0;

// Embedder callbacks.

- virtual void addExecutionContextToFrontend(int executionContextId, const String& type, const String& origin, const String& humanReadableName, const String& frameId) = 0;

+ virtual void reportExecutionContextCreated(int executionContextId, const String& type, const String& origin, const String& humanReadableName, const String& frameId) = 0;

};

} // namespace blink