Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1441683008: Move GrGLPrimitive/GeometryProc to GLSL (Closed)

Created:
5 years, 1 month ago by egdaniel
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@xferProcs
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move GrGLPrimitive/GeometryProc to GLSL BUG=skia: Committed: https://skia.googlesource.com/skia/+/e659a581f63fdccb64dce2dc8a478cf56831feea

Patch Set 1 #

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -532 lines) Patch
M gyp/gpu.gypi View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 7 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrPathProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrPathProcessor.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrPrimitiveProcessor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 9 chunks +10 lines, -11 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 9 chunks +9 lines, -10 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 10 chunks +10 lines, -11 lines 0 comments Download
D src/gpu/gl/GrGLGeometryProcessor.h View 1 chunk +0 lines, -110 lines 0 comments Download
D src/gpu/gl/GrGLGeometryProcessor.cpp View 1 chunk +0 lines, -157 lines 0 comments Download
D src/gpu/gl/GrGLPrimitiveProcessor.h View 1 chunk +0 lines, -92 lines 0 comments Download
D src/gpu/gl/GrGLPrimitiveProcessor.cpp View 1 chunk +0 lines, -47 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
A + src/gpu/glsl/GrGLSLGeometryProcessor.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + src/gpu/glsl/GrGLSLGeometryProcessor.cpp View 1 3 chunks +20 lines, -20 lines 0 comments Download
A + src/gpu/glsl/GrGLSLPrimitiveProcessor.h View 3 chunks +8 lines, -8 lines 0 comments Download
A + src/gpu/glsl/GrGLSLPrimitiveProcessor.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M tools/BUILD.public.expected View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441683008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441683008/20001
5 years, 1 month ago (2015-11-13 17:40:17 UTC) #2
egdaniel
Another one of my simple renaming cls
5 years, 1 month ago (2015-11-13 17:40:39 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-13 17:51:23 UTC) #6
ethannicholas
lgtm
5 years, 1 month ago (2015-11-13 17:53:13 UTC) #7
jvanverth1
lgtm
5 years, 1 month ago (2015-11-13 17:53:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1441683008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1441683008/20001
5 years, 1 month ago (2015-11-13 17:54:56 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-11-13 17:55:46 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e659a581f63fdccb64dce2dc8a478cf56831feea

Powered by Google App Engine
This is Rietveld 408576698