Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 135563002: Update remaining rendering classes to use OVERRIDE / FINAL when needed (Closed)

Created:
6 years, 11 months ago by Inactive
Modified:
6 years, 11 months ago
Reviewers:
pdr., esprehn, eseidel
CC:
blink-reviews, krit, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, f(malita), jchaffraix+rendering, pdr, Stephen Chennney, rwlbuis
Visibility:
Public.

Description

Update remaining rendering classes to use OVERRIDE / FINAL when needed Update remaining rendering classes to use OVERRIDE / FINAL when needed. Those are useful for error checking or performance when the compiler supports it. R=eseidel, esprehn BUG=333316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164934

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -282 lines) Patch
M Source/core/rendering/shapes/BoxShape.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/shapes/PolygonShape.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/shapes/RasterShape.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/shapes/RectangleShape.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/BasicShapes.h View 14 chunks +15 lines, -15 lines 0 comments Download
M Source/core/rendering/style/ContentData.h View 7 chunks +8 lines, -8 lines 0 comments Download
M Source/core/rendering/style/StyleFetchedImage.h View 1 chunk +14 lines, -14 lines 0 comments Download
M Source/core/rendering/style/StyleFetchedImageSet.h View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/core/rendering/style/StyleGeneratedImage.h View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/core/rendering/style/StylePendingImage.h View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGBlock.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGContainer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGEllipse.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGForeignObject.h View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGGradientStop.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGHiddenContainer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGImage.h View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGInline.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGInlineText.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGModelObject.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGPath.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGRect.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceLinearGradient.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMarker.h View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourcePattern.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceRadialGradient.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceSolidColor.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.h View 4 chunks +19 lines, -19 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGTSpan.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGText.h View 3 chunks +18 lines, -18 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGTextPath.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGTransformableContainer.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGViewportContainer.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineFlowBox.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/rendering/svg/SVGRootInlineBox.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/rendering/svg/SVGTextRunRenderingContext.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
6 years, 11 months ago (2014-01-11 17:45:01 UTC) #1
pdr.
On 2014/01/11 17:45:01, Chris Dumez wrote: LGTM, rs=me
6 years, 11 months ago (2014-01-11 17:58:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/135563002/1
6 years, 11 months ago (2014-01-11 18:00:22 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-11 18:06:49 UTC) #4
Message was sent while issue was closed. 
Change committed as 164934

Powered by Google App Engine
This is Rietveld 408576698