Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 1229743005: Fix virtual/override/final usage in Source/core/{fetch,loader,streams,xmlhttprequest}/. (Closed)

Created:
5 years, 5 months ago by tkent
Modified:
5 years, 5 months ago
CC:
blink-reviews, tyoshino+watch_chromium.org, nessy, gavinp+prerender_chromium.org, blink-reviews-style_chromium.org, philipj_slow, gasubic, Yoav Weiss, eric.carlson_apple.com, fs, gavinp+loader_chromium.org, Nate Chapin, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix virtual/override/final usage in Source/core/{fetch,loader,streams,xmlhttprequest}/. - We should specify just one of them to a function. This was done by the following command. % sed -i "" -E "s/virtual (.*) final/\1 final/g; s/virtual (.*) override/\1 override/g; s/override final/final/g" <files> - Non-base virtual destructors should have |override| keywords. - Also replace { } with {} for updated lines to align with Chromium style. This CL has no behavior changes. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198581

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -336 lines) Patch
M Source/core/fetch/CSSStyleSheetResource.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/fetch/DocumentResource.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/fetch/DocumentResourceReference.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/FontResource.h View 4 chunks +12 lines, -12 lines 0 comments Download
M Source/core/fetch/ImageResource.h View 2 chunks +19 lines, -19 lines 0 comments Download
M Source/core/fetch/ImageResourceClient.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/fetch/LinkFetchResource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/MemoryCache.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/fetch/MemoryCacheTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/fetch/MockImageResourceClient.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/fetch/RawResource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/fetch/RawResourceTest.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/fetch/ResourceLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ScriptResource.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/fetch/StyleSheetResourceClient.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/fetch/TextResource.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/fetch/XSLStyleSheetResource.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/DocumentLoader.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/loader/DocumentThreadableLoader.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/loader/DocumentThreadableLoaderClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/EmptyClients.h View 4 chunks +128 lines, -128 lines 0 comments Download
M Source/core/loader/EmptyClients.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/loader/FrameFetchContext.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/ImageLoader.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/loader/LinkLoader.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/loader/LinkLoaderTest.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/loader/NavigationScheduler.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/loader/PingLoader.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/loader/PrerenderHandle.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/SinkDocument.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/SinkDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/TextTrackLoader.h View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/loader/WorkerLoaderClientBridge.h View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/core/loader/WorkerLoaderClientBridgeSyncHelper.h View 1 chunk +11 lines, -11 lines 0 comments Download
M Source/core/loader/WorkerThreadableLoader.h View 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/loader/appcache/ApplicationCache.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/loader/appcache/ApplicationCacheHost.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/streams/Stream.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.h View 1 4 chunks +16 lines, -16 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequestProgressEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequestUpload.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
tkent
tyoshino or yhirano, would you review this trivial change please?
5 years, 5 months ago (2015-07-09 05:04:20 UTC) #3
yhirano
On 2015/07/09 05:04:20, tkent wrote: > tyoshino or yhirano, would you review this trivial change ...
5 years, 5 months ago (2015-07-09 05:11:55 UTC) #4
yhirano
You replace some "{ }" with "{}", but some remain unchanged (e.g. Source/core/fetch/CSSStyleSheetResource.h:67). Is this ...
5 years, 5 months ago (2015-07-09 05:36:38 UTC) #5
tkent
On 2015/07/09 05:36:38, yhirano wrote: > You replace some "{ }" with "{}", but some ...
5 years, 5 months ago (2015-07-09 06:14:39 UTC) #6
tyoshino (SeeGerritForStatus)
lgtm
5 years, 5 months ago (2015-07-09 06:25:01 UTC) #7
yhirano
lgtm
5 years, 5 months ago (2015-07-09 06:47:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1229743005/40001
5 years, 5 months ago (2015-07-09 07:24:45 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 07:29:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198581

Powered by Google App Engine
This is Rietveld 408576698