Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Side by Side Diff: Source/core/fetch/ScriptResource.h

Issue 1229743005: Fix virtual/override/final usage in Source/core/{fetch,loader,streams,xmlhttprequest}/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/fetch/ResourceLoader.h ('k') | Source/core/fetch/StyleSheetResourceClient.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de) 2 Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org> 3 Copyright (C) 2001 Dirk Mueller <mueller@kde.org>
4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 4 Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
5 Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 5 Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
6 6
7 This library is free software; you can redistribute it and/or 7 This library is free software; you can redistribute it and/or
8 modify it under the terms of the GNU Library General Public 8 modify it under the terms of the GNU Library General Public
9 License as published by the Free Software Foundation; either 9 License as published by the Free Software Foundation; either
10 version 2 of the License, or (at your option) any later version. 10 version 2 of the License, or (at your option) any later version.
(...skipping 19 matching lines...) Expand all
30 #include "core/fetch/ResourceClient.h" 30 #include "core/fetch/ResourceClient.h"
31 #include "core/fetch/TextResource.h" 31 #include "core/fetch/TextResource.h"
32 32
33 namespace blink { 33 namespace blink {
34 34
35 class FetchRequest; 35 class FetchRequest;
36 class ScriptResource; 36 class ScriptResource;
37 37
38 class CORE_EXPORT ScriptResourceClient : public ResourceClient { 38 class CORE_EXPORT ScriptResourceClient : public ResourceClient {
39 public: 39 public:
40 virtual ~ScriptResourceClient() { } 40 ~ScriptResourceClient() override {}
41 static ResourceClientType expectedType() { return ScriptType; } 41 static ResourceClientType expectedType() { return ScriptType; }
42 virtual ResourceClientType resourceClientType() const override final { retur n expectedType(); } 42 ResourceClientType resourceClientType() const final { return expectedType(); }
43 43
44 virtual void notifyAppendData(ScriptResource* resource) { } 44 virtual void notifyAppendData(ScriptResource* resource) { }
45 }; 45 };
46 46
47 class CORE_EXPORT ScriptResource final : public TextResource { 47 class CORE_EXPORT ScriptResource final : public TextResource {
48 public: 48 public:
49 typedef ScriptResourceClient ClientType; 49 typedef ScriptResourceClient ClientType;
50 static ResourcePtr<ScriptResource> fetch(FetchRequest&, ResourceFetcher*); 50 static ResourcePtr<ScriptResource> fetch(FetchRequest&, ResourceFetcher*);
51 51
52 // Public for testing 52 // Public for testing
53 ScriptResource(const ResourceRequest&, const String& charset); 53 ScriptResource(const ResourceRequest&, const String& charset);
54 54
55 virtual ~ScriptResource(); 55 ~ScriptResource() override;
56 56
57 virtual void didAddClient(ResourceClient*) override; 57 void didAddClient(ResourceClient*) override;
58 virtual void appendData(const char*, unsigned) override; 58 void appendData(const char*, unsigned) override;
59 59
60 const String& script(); 60 const String& script();
61 61
62 AtomicString mimeType() const; 62 AtomicString mimeType() const;
63 63
64 bool mimeTypeAllowedByNosniff() const; 64 bool mimeTypeAllowedByNosniff() const;
65 65
66 private: 66 private:
67 class ScriptResourceFactory : public ResourceFactory { 67 class ScriptResourceFactory : public ResourceFactory {
68 public: 68 public:
69 ScriptResourceFactory() 69 ScriptResourceFactory()
70 : ResourceFactory(Resource::Script) { } 70 : ResourceFactory(Resource::Script) { }
71 71
72 Resource* create(const ResourceRequest& request, const String& charset) const override 72 Resource* create(const ResourceRequest& request, const String& charset) const override
73 { 73 {
74 return new ScriptResource(request, charset); 74 return new ScriptResource(request, charset);
75 } 75 }
76 }; 76 };
77 77
78 AtomicString m_script; 78 AtomicString m_script;
79 }; 79 };
80 80
81 DEFINE_RESOURCE_TYPE_CASTS(Script); 81 DEFINE_RESOURCE_TYPE_CASTS(Script);
82 82
83 } 83 }
84 84
85 #endif 85 #endif
OLDNEW
« no previous file with comments | « Source/core/fetch/ResourceLoader.h ('k') | Source/core/fetch/StyleSheetResourceClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698