Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: Source/core/xmlhttprequest/XMLHttpRequestUpload.h

Issue 1229743005: Fix virtual/override/final usage in Source/core/{fetch,loader,streams,xmlhttprequest}/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xmlhttprequest/XMLHttpRequestUpload.h
diff --git a/Source/core/xmlhttprequest/XMLHttpRequestUpload.h b/Source/core/xmlhttprequest/XMLHttpRequestUpload.h
index 26cde6b5c4f9c26fdda5c7639fc33b5031683ea4..df508a4dcdf816bcad9ab4dca83b2d2f888f0c18 100644
--- a/Source/core/xmlhttprequest/XMLHttpRequestUpload.h
+++ b/Source/core/xmlhttprequest/XMLHttpRequestUpload.h
@@ -54,8 +54,8 @@ public:
XMLHttpRequest* xmlHttpRequest() const { return m_xmlHttpRequest; }
- virtual const AtomicString& interfaceName() const override;
- virtual ExecutionContext* executionContext() const override;
+ const AtomicString& interfaceName() const override;
+ ExecutionContext* executionContext() const override;
void dispatchEventAndLoadEnd(const AtomicString&, bool, unsigned long long, unsigned long long);
void dispatchProgressEvent(unsigned long long, unsigned long long);
@@ -68,8 +68,8 @@ private:
explicit XMLHttpRequestUpload(XMLHttpRequest*);
#if !ENABLE(OILPAN)
- virtual void refEventTarget() override { ref(); }
- virtual void derefEventTarget() override { deref(); }
+ void refEventTarget() override { ref(); }
+ void derefEventTarget() override { deref(); }
#endif
RawPtrWillBeMember<XMLHttpRequest> m_xmlHttpRequest;
« no previous file with comments | « Source/core/xmlhttprequest/XMLHttpRequestProgressEventThrottle.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698