Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: Source/core/fetch/DocumentResource.h

Issue 1229743005: Fix virtual/override/final usage in Source/core/{fetch,loader,streams,xmlhttprequest}/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 Copyright (C) 2010 Rob Buis <rwlbuis@gmail.com> 2 Copyright (C) 2010 Rob Buis <rwlbuis@gmail.com>
3 Copyright (C) 2011 Cosmin Truta <ctruta@gmail.com> 3 Copyright (C) 2011 Cosmin Truta <ctruta@gmail.com>
4 Copyright (C) 2012 University of Szeged 4 Copyright (C) 2012 University of Szeged
5 Copyright (C) 2012 Renata Hodovan <reni@webkit.org> 5 Copyright (C) 2012 Renata Hodovan <reni@webkit.org>
6 6
7 This library is free software; you can redistribute it and/or 7 This library is free software; you can redistribute it and/or
8 modify it under the terms of the GNU Library General Public 8 modify it under the terms of the GNU Library General Public
9 License as published by the Free Software Foundation; either 9 License as published by the Free Software Foundation; either
10 version 2 of the License, or (at your option) any later version. 10 version 2 of the License, or (at your option) any later version.
(...skipping 21 matching lines...) Expand all
32 32
33 class Document; 33 class Document;
34 class FetchRequest; 34 class FetchRequest;
35 class ResourceFetcher; 35 class ResourceFetcher;
36 36
37 class DocumentResource final : public Resource { 37 class DocumentResource final : public Resource {
38 public: 38 public:
39 typedef ResourceClient ClientType; 39 typedef ResourceClient ClientType;
40 40
41 static ResourcePtr<DocumentResource> fetchSVGDocument(FetchRequest&, Resourc eFetcher*); 41 static ResourcePtr<DocumentResource> fetchSVGDocument(FetchRequest&, Resourc eFetcher*);
42 virtual ~DocumentResource(); 42 ~DocumentResource() override;
43 DECLARE_VIRTUAL_TRACE(); 43 DECLARE_VIRTUAL_TRACE();
44 44
45 Document* document() const { return m_document.get(); } 45 Document* document() const { return m_document.get(); }
46 46
47 virtual void setEncoding(const String&) override; 47 void setEncoding(const String&) override;
48 virtual String encoding() const override; 48 String encoding() const override;
49 virtual void checkNotify() override; 49 void checkNotify() override;
50 50
51 private: 51 private:
52 class SVGDocumentResourceFactory : public ResourceFactory { 52 class SVGDocumentResourceFactory : public ResourceFactory {
53 public: 53 public:
54 SVGDocumentResourceFactory() 54 SVGDocumentResourceFactory()
55 : ResourceFactory(Resource::SVGDocument) { } 55 : ResourceFactory(Resource::SVGDocument) { }
56 56
57 Resource* create(const ResourceRequest& request, const String& charset) const override 57 Resource* create(const ResourceRequest& request, const String& charset) const override
58 { 58 {
59 return new DocumentResource(request, Resource::SVGDocument); 59 return new DocumentResource(request, Resource::SVGDocument);
60 } 60 }
61 }; 61 };
62 DocumentResource(const ResourceRequest&, Type); 62 DocumentResource(const ResourceRequest&, Type);
63 63
64 PassRefPtrWillBeRawPtr<Document> createDocument(const KURL&); 64 PassRefPtrWillBeRawPtr<Document> createDocument(const KURL&);
65 65
66 RefPtrWillBeMember<Document> m_document; 66 RefPtrWillBeMember<Document> m_document;
67 OwnPtr<TextResourceDecoder> m_decoder; 67 OwnPtr<TextResourceDecoder> m_decoder;
68 }; 68 };
69 69
70 DEFINE_TYPE_CASTS(DocumentResource, Resource, resource, resource->type() == Reso urce::SVGDocument, resource.type() == Resource::SVGDocument); \ 70 DEFINE_TYPE_CASTS(DocumentResource, Resource, resource, resource->type() == Reso urce::SVGDocument, resource.type() == Resource::SVGDocument); \
71 inline DocumentResource* toDocumentResource(const ResourcePtr<Resource>& ptr) { return toDocumentResource(ptr.get()); } 71 inline DocumentResource* toDocumentResource(const ResourcePtr<Resource>& ptr) { return toDocumentResource(ptr.get()); }
72 72
73 class DocumentResourceClient : public ResourceClient { 73 class DocumentResourceClient : public ResourceClient {
74 public: 74 public:
75 virtual ~DocumentResourceClient() { } 75 ~DocumentResourceClient() override {}
76 static ResourceClientType expectedType() { return DocumentType; } 76 static ResourceClientType expectedType() { return DocumentType; }
77 virtual ResourceClientType resourceClientType() const override { return expe ctedType(); } 77 ResourceClientType resourceClientType() const override { return expectedType (); }
78 }; 78 };
79 79
80 } 80 }
81 81
82 #endif // DocumentResource_h 82 #endif // DocumentResource_h
OLDNEW
« no previous file with comments | « Source/core/fetch/CSSStyleSheetResource.h ('k') | Source/core/fetch/DocumentResourceReference.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698