Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1462)

Unified Diff: Source/core/loader/WorkerThreadableLoader.h

Issue 1229743005: Fix virtual/override/final usage in Source/core/{fetch,loader,streams,xmlhttprequest}/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/WorkerThreadableLoader.h
diff --git a/Source/core/loader/WorkerThreadableLoader.h b/Source/core/loader/WorkerThreadableLoader.h
index 1547152c57810961f862deef4f2e861adbead96c..7991f822e7db6175f2caedbbc722ff72e4dec0a3 100644
--- a/Source/core/loader/WorkerThreadableLoader.h
+++ b/Source/core/loader/WorkerThreadableLoader.h
@@ -59,11 +59,11 @@ namespace blink {
return adoptRef(new WorkerThreadableLoader(workerGlobalScope, clientWrapper, clientBridge, request, options, resourceLoaderOptions));
}
- virtual ~WorkerThreadableLoader();
+ ~WorkerThreadableLoader() override;
- virtual void overrideTimeout(unsigned long timeout) override;
+ void overrideTimeout(unsigned long timeout) override;
- virtual void cancel() override;
+ void cancel() override;
private:
// Creates a loader on the main thread and bridges communication between
@@ -99,21 +99,21 @@ namespace blink {
// All executed on the main thread.
void mainThreadDestroy(ExecutionContext*);
- virtual ~MainThreadBridge();
+ ~MainThreadBridge() override;
void mainThreadCreateLoader(PassOwnPtr<CrossThreadResourceRequestData>, ThreadableLoaderOptions, ResourceLoaderOptions, const ReferrerPolicy, const String& outgoingReferrer, ExecutionContext*);
void mainThreadOverrideTimeout(unsigned long timeoutMilliseconds, ExecutionContext*);
void mainThreadCancel(ExecutionContext*);
- virtual void didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent) override;
- virtual void didReceiveResponse(unsigned long identifier, const ResourceResponse&, PassOwnPtr<WebDataConsumerHandle>) override;
- virtual void didReceiveData(const char*, unsigned dataLength) override;
- virtual void didDownloadData(int dataLength) override;
- virtual void didReceiveCachedMetadata(const char*, int dataLength) override;
- virtual void didFinishLoading(unsigned long identifier, double finishTime) override;
- virtual void didFail(const ResourceError&) override;
- virtual void didFailAccessControlCheck(const ResourceError&) override;
- virtual void didFailRedirectCheck() override;
- virtual void didReceiveResourceTiming(const ResourceTimingInfo&) override;
+ void didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent) override;
+ void didReceiveResponse(unsigned long identifier, const ResourceResponse&, PassOwnPtr<WebDataConsumerHandle>) override;
+ void didReceiveData(const char*, unsigned dataLength) override;
+ void didDownloadData(int dataLength) override;
+ void didReceiveCachedMetadata(const char*, int dataLength) override;
+ void didFinishLoading(unsigned long identifier, double finishTime) override;
+ void didFail(const ResourceError&) override;
+ void didFailAccessControlCheck(const ResourceError&) override;
+ void didFailRedirectCheck() override;
+ void didReceiveResourceTiming(const ResourceTimingInfo&) override;
// Only to be used on the main thread.
RefPtr<ThreadableLoader> m_mainThreadLoader;
« no previous file with comments | « Source/core/loader/WorkerLoaderClientBridgeSyncHelper.h ('k') | Source/core/loader/appcache/ApplicationCache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698