Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1725)

Unified Diff: Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 1229743005: Fix virtual/override/final usage in Source/core/{fetch,loader,streams,xmlhttprequest}/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/xmlhttprequest/XMLHttpRequest.cpp
diff --git a/Source/core/xmlhttprequest/XMLHttpRequest.cpp b/Source/core/xmlhttprequest/XMLHttpRequest.cpp
index f2ee9b1735e721ece197342204a99c54fc5c6740..36614aa269ae93774d50e0ecad1d38cb6a2d881e 100644
--- a/Source/core/xmlhttprequest/XMLHttpRequest.cpp
+++ b/Source/core/xmlhttprequest/XMLHttpRequest.cpp
@@ -144,17 +144,17 @@ public:
}
// FileReaderLoaderClient functions.
- virtual void didStartLoading() override { }
- virtual void didReceiveDataForClient(const char* data, unsigned length) override
+ void didStartLoading() override {}
+ void didReceiveDataForClient(const char* data, unsigned length) override
{
ASSERT(length <= INT_MAX);
m_xhr->didReceiveData(data, length);
}
- virtual void didFinishLoading() override
+ void didFinishLoading() override
{
m_xhr->didFinishLoadingFromBlob();
}
- virtual void didFail(FileError::ErrorCode error) override
+ void didFail(FileError::ErrorCode error) override
{
m_xhr->didFailLoadingFromBlob();
}
« no previous file with comments | « Source/core/xmlhttprequest/XMLHttpRequest.h ('k') | Source/core/xmlhttprequest/XMLHttpRequestProgressEvent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698