Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: Source/core/loader/NavigationScheduler.cpp

Issue 1229743005: Fix virtual/override/final usage in Source/core/{fetch,loader,streams,xmlhttprequest}/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/LinkLoaderTest.cpp ('k') | Source/core/loader/PingLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/NavigationScheduler.cpp
diff --git a/Source/core/loader/NavigationScheduler.cpp b/Source/core/loader/NavigationScheduler.cpp
index acdf5260e480067af04b6de7f50399a50cd555dc..d0c845c518d0daac9b92df45f176494d3ed50ac0 100644
--- a/Source/core/loader/NavigationScheduler.cpp
+++ b/Source/core/loader/NavigationScheduler.cpp
@@ -123,7 +123,7 @@ protected:
m_shouldCheckMainWorldContentSecurityPolicy = DoNotCheckContentSecurityPolicy;
}
- virtual void fire(LocalFrame* frame) override
+ void fire(LocalFrame* frame) override
{
OwnPtr<UserGestureIndicator> gestureIndicator = createUserGestureIndicator();
FrameLoadRequest request(originDocument(), m_url, "_self", m_shouldCheckMainWorldContentSecurityPolicy);
@@ -146,9 +146,9 @@ public:
return adoptPtrWillBeNoop(new ScheduledRedirect(delay, originDocument, url, lockBackForwardList));
}
- virtual bool shouldStartTimer(LocalFrame* frame) override { return frame->document()->loadEventFinished(); }
+ bool shouldStartTimer(LocalFrame* frame) override { return frame->document()->loadEventFinished(); }
- virtual void fire(LocalFrame* frame) override
+ void fire(LocalFrame* frame) override
{
OwnPtr<UserGestureIndicator> gestureIndicator = createUserGestureIndicator();
FrameLoadRequest request(originDocument(), url(), "_self");
@@ -185,7 +185,7 @@ public:
return adoptPtrWillBeNoop(new ScheduledReload);
}
- virtual void fire(LocalFrame* frame) override
+ void fire(LocalFrame* frame) override
{
OwnPtr<UserGestureIndicator> gestureIndicator = createUserGestureIndicator();
ResourceRequest resourceRequest =
@@ -211,7 +211,7 @@ public:
return adoptPtrWillBeNoop(new ScheduledPageBlock(originDocument, url));
}
- virtual void fire(LocalFrame* frame) override
+ void fire(LocalFrame* frame) override
{
OwnPtr<UserGestureIndicator> gestureIndicator = createUserGestureIndicator();
SubstituteData substituteData(SharedBuffer::create(), "text/plain", "UTF-8", KURL(), ForceSynchronousLoad);
@@ -235,7 +235,7 @@ public:
return adoptPtrWillBeNoop(new ScheduledFormSubmission(document, submission, lockBackForwardList));
}
- virtual void fire(LocalFrame* frame) override
+ void fire(LocalFrame* frame) override
{
OwnPtr<UserGestureIndicator> gestureIndicator = createUserGestureIndicator();
FrameLoadRequest frameRequest(originDocument());
« no previous file with comments | « Source/core/loader/LinkLoaderTest.cpp ('k') | Source/core/loader/PingLoader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698