Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: Source/core/loader/EmptyClients.cpp

Issue 1229743005: Fix virtual/override/final usage in Source/core/{fetch,loader,streams,xmlhttprequest}/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/loader/EmptyClients.h ('k') | Source/core/loader/FrameFetchContext.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org> 2 * Copyright (C) 2006 Eric Seidel <eric@webkit.org>
3 * Copyright (C) 2008, 2009, 2012 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2012 Apple Inc. All rights reserved.
4 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 4 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 55
56 static EditorClient* dummyEditorClient = adoptPtr(new EmptyEditorClient).lea kPtr(); 56 static EditorClient* dummyEditorClient = adoptPtr(new EmptyEditorClient).lea kPtr();
57 pageClients.editorClient = dummyEditorClient; 57 pageClients.editorClient = dummyEditorClient;
58 58
59 static SpellCheckerClient* dummySpellCheckerClient = adoptPtr(new EmptySpell CheckerClient).leakPtr(); 59 static SpellCheckerClient* dummySpellCheckerClient = adoptPtr(new EmptySpell CheckerClient).leakPtr();
60 pageClients.spellCheckerClient = dummySpellCheckerClient; 60 pageClients.spellCheckerClient = dummySpellCheckerClient;
61 } 61 }
62 62
63 class EmptyPopupMenu : public PopupMenu { 63 class EmptyPopupMenu : public PopupMenu {
64 public: 64 public:
65 virtual void show(const FloatQuad&, const IntSize&, int) override { } 65 void show(const FloatQuad&, const IntSize&, int) override { }
66 virtual void hide() override { } 66 void hide() override { }
67 virtual void updateFromElement() override { } 67 void updateFromElement() override { }
68 virtual void disconnectClient() override { } 68 void disconnectClient() override { }
69 }; 69 };
70 70
71 PassRefPtrWillBeRawPtr<PopupMenu> EmptyChromeClient::openPopupMenu(LocalFrame&, PopupMenuClient*) 71 PassRefPtrWillBeRawPtr<PopupMenu> EmptyChromeClient::openPopupMenu(LocalFrame&, PopupMenuClient*)
72 { 72 {
73 return adoptRefWillBeNoop(new EmptyPopupMenu()); 73 return adoptRefWillBeNoop(new EmptyPopupMenu());
74 } 74 }
75 75
76 PassOwnPtrWillBeRawPtr<ColorChooser> EmptyChromeClient::openColorChooser(LocalFr ame*, ColorChooserClient*, const Color&) 76 PassOwnPtrWillBeRawPtr<ColorChooser> EmptyChromeClient::openColorChooser(LocalFr ame*, ColorChooserClient*, const Color&)
77 { 77 {
78 return nullptr; 78 return nullptr;
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 { 151 {
152 return nullptr; 152 return nullptr;
153 } 153 }
154 154
155 PassOwnPtr<WebApplicationCacheHost> EmptyFrameLoaderClient::createApplicationCac heHost(WebApplicationCacheHostClient*) 155 PassOwnPtr<WebApplicationCacheHost> EmptyFrameLoaderClient::createApplicationCac heHost(WebApplicationCacheHostClient*)
156 { 156 {
157 return nullptr; 157 return nullptr;
158 } 158 }
159 159
160 } // namespace blink 160 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/loader/EmptyClients.h ('k') | Source/core/loader/FrameFetchContext.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698