Fix virtual/override/final usage in Source/core/{fetch,loader,streams,xmlhttprequest}/.

Source/core/loader/EmptyClients.h

Index: Source/core/loader/EmptyClients.h
diff --git a/Source/core/loader/EmptyClients.h b/Source/core/loader/EmptyClients.h
index 222187c00d73258c349255ed5e61fbdc40a93b7a..5e03dbe20de1e47c1caef3199eb9f4460967a432 100644
--- a/Source/core/loader/EmptyClients.h
+++ b/Source/core/loader/EmptyClients.h
@@ -67,48 +67,48 @@ namespace blink {
 class CORE_EXPORT EmptyChromeClient : public ChromeClient {
     WTF_MAKE_FAST_ALLOCATED(EmptyChromeClient);
 public:
-    ~EmptyChromeClient() override { }
-    void chromeDestroyed() override { }
+    ~EmptyChromeClient() override {}
+    void chromeDestroyed() override {}
 
     void* webView() const override { return nullptr; }
-    void setWindowRect(const IntRect&) override { }
+    void setWindowRect(const IntRect&) override {}
     IntRect windowRect() override { return IntRect(); }
 
     IntRect pageRect() override { return IntRect(); }
 
-    void focus() override { }
+    void focus() override {}
 
     bool canTakeFocus(WebFocusType) override { return false; }
-    void takeFocus(WebFocusType) override { }
+    void takeFocus(WebFocusType) override {}
 
-    void focusedNodeChanged(Node*, Node*) override { }
-    void focusedFrameChanged(LocalFrame*) override { }
+    void focusedNodeChanged(Node*, Node*) override {}
+    void focusedFrameChanged(LocalFrame*) override {}
     Page* createWindow(LocalFrame*, const FrameLoadRequest&, const WindowFeatures&, NavigationPolicy, ShouldSendReferrer) override { return nullptr; }
-    void show(NavigationPolicy) override { }
+    void show(NavigationPolicy) override {}
 
-    void didOverscroll(const FloatSize&, const FloatSize&, const FloatPoint&, const FloatSize&) override { }
+    void didOverscroll(const FloatSize&, const FloatSize&, const FloatPoint&, const FloatSize&) override {}
 
-    void setToolbarsVisible(bool) override { }
+    void setToolbarsVisible(bool) override {}
     bool toolbarsVisible() override { return false; }
 
-    void setStatusbarVisible(bool) override { }
+    void setStatusbarVisible(bool) override {}
     bool statusbarVisible() override { return false; }
 
-    void setScrollbarsVisible(bool) override { }
+    void setScrollbarsVisible(bool) override {}
     bool scrollbarsVisible() override { return false; }
 
-    void setMenubarVisible(bool) override { }
+    void setMenubarVisible(bool) override {}
     bool menubarVisible() override { return false; }
 
-    void setResizable(bool) override { }
+    void setResizable(bool) override {}
 
     bool shouldReportDetailedMessageForSource(LocalFrame&, const String&) override { return false; }
-    void addMessageToConsole(LocalFrame*, MessageSource, MessageLevel, const String&, unsigned, const String&, const String&) override { }
+    void addMessageToConsole(LocalFrame*, MessageSource, MessageLevel, const String&, unsigned, const String&, const String&) override {}
 
     bool canOpenBeforeUnloadConfirmPanel() override { return false; }
     bool openBeforeUnloadConfirmPanelDelegate(LocalFrame*, const String&) override { return true; }
 
-    void closeWindowSoon() override { }
+    void closeWindowSoon() override {}
 
     bool openJavaScriptAlertDelegate(LocalFrame*, const String&) override { return false; }
     bool openJavaScriptConfirmDelegate(LocalFrame*, const String&) override { return false; }
@@ -118,26 +118,26 @@ public:
     PassRefPtrWillBeRawPtr<PopupMenu> openPopupMenu(LocalFrame&, PopupMenuClient*) override;
     DOMWindow* pagePopupWindowForTesting() const override { return nullptr; }
 
-    void setStatusbarText(const String&) override { }
+    void setStatusbarText(const String&) override {}
 
     bool tabsToLinks() override { return false; }
 
     IntRect windowResizerRect() const override { return IntRect(); }
 
-    void invalidateRect(const IntRect&) override { }
-    void scheduleAnimation() override { }
+    void invalidateRect(const IntRect&) override {}
+    void scheduleAnimation() override {}
 
     IntRect viewportToScreen(const IntRect& r) const override { return r; }
     WebScreenInfo screenInfo() const override { return WebScreenInfo(); }
-    void contentsSizeChanged(LocalFrame*, const IntSize&) const override { }
+    void contentsSizeChanged(LocalFrame*, const IntSize&) const override {}
 
-    void showMouseOverURL(const HitTestResult&) override { }
+    void showMouseOverURL(const HitTestResult&) override {}
 
-    void setToolTip(const String&, TextDirection) override { }
+    void setToolTip(const String&, TextDirection) override {}
 
-    void printDelegate(LocalFrame*) override { }
+    void printDelegate(LocalFrame*) override {}
 
-    void enumerateChosenDirectory(FileChooser*) override { }
+    void enumerateChosenDirectory(FileChooser*) override {}
 
     PassOwnPtrWillBeRawPtr<ColorChooser> openColorChooser(LocalFrame*, ColorChooserClient*, const Color&) override;
     PassRefPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&) override;
@@ -145,143 +145,143 @@ public:
 
     void openFileChooser(LocalFrame*, PassRefPtr<FileChooser>) override;
 
-    void setCursor(const Cursor&) override { }
+    void setCursor(const Cursor&) override {}
     Cursor lastSetCursorForTesting() const override { return pointerCursor(); }
 
-    void attachRootGraphicsLayer(GraphicsLayer*, LocalFrame* localRoot) override { }
+    void attachRootGraphicsLayer(GraphicsLayer*, LocalFrame* localRoot) override {}
 
-    void needTouchEvents(bool) override { }
-    void setTouchAction(TouchAction) override { }
+    void needTouchEvents(bool) override {}
+    void setTouchAction(TouchAction) override {}
 
-    void didAssociateFormControls(const WillBeHeapVector<RefPtrWillBeMember<Element>>&, LocalFrame*) override { }
+    void didAssociateFormControls(const WillBeHeapVector<RefPtrWillBeMember<Element>>&, LocalFrame*) override {}
 
-    void annotatedRegionsChanged() override { }
+    void annotatedRegionsChanged() override {}
     String acceptLanguages() override;
 
-    void registerPopupOpeningObserver(PopupOpeningObserver*) override { }
-    void unregisterPopupOpeningObserver(PopupOpeningObserver*) override { }
+    void registerPopupOpeningObserver(PopupOpeningObserver*) override {}
+    void unregisterPopupOpeningObserver(PopupOpeningObserver*) override {}
 };
 
 class CORE_EXPORT EmptyFrameLoaderClient : public FrameLoaderClient {
     WTF_MAKE_NONCOPYABLE(EmptyFrameLoaderClient); WTF_MAKE_FAST_ALLOCATED(EmptyFrameLoaderClient);
 public:
-    EmptyFrameLoaderClient() { }
-    virtual ~EmptyFrameLoaderClient() { }
+    EmptyFrameLoaderClient() {}
+    ~EmptyFrameLoaderClient() override {}
 
-    virtual bool hasWebView() const override { return true; } // mainly for assertions
+    bool hasWebView() const override { return true; } // mainly for assertions
 
-    virtual bool inShadowTree() const override { return false; }
+    bool inShadowTree() const override { return false; }
 
-    virtual Frame* opener() const override { return 0; }
-    virtual void setOpener(Frame*) override { }
+    Frame* opener() const override { return 0; }
+    void setOpener(Frame*) override {}
 
-    virtual Frame* parent() const override { return 0; }
-    virtual Frame* top() const override { return 0; }
-    virtual Frame* previousSibling() const override { return 0; }
-    virtual Frame* nextSibling() const override { return 0; }
-    virtual Frame* firstChild() const override { return 0; }
-    virtual Frame* lastChild() const override { return 0; }
-    virtual void willBeDetached() override { }
-    virtual void detached(FrameDetachType) override { }
+    Frame* parent() const override { return 0; }
+    Frame* top() const override { return 0; }
+    Frame* previousSibling() const override { return 0; }
+    Frame* nextSibling() const override { return 0; }
+    Frame* firstChild() const override { return 0; }
+    Frame* lastChild() const override { return 0; }
+    void willBeDetached() override {}
+    void detached(FrameDetachType) override {}
 
-    virtual void dispatchWillSendRequest(DocumentLoader*, unsigned long, ResourceRequest&, const ResourceResponse&) override { }
-    virtual void dispatchDidReceiveResponse(DocumentLoader*, unsigned long, const ResourceResponse&) override { }
-    virtual void dispatchDidFinishLoading(DocumentLoader*, unsigned long) override { }
-    virtual void dispatchDidLoadResourceFromMemoryCache(const ResourceRequest&, const ResourceResponse&) override { }
+    void dispatchWillSendRequest(DocumentLoader*, unsigned long, ResourceRequest&, const ResourceResponse&) override {}
+    void dispatchDidReceiveResponse(DocumentLoader*, unsigned long, const ResourceResponse&) override {}
+    void dispatchDidFinishLoading(DocumentLoader*, unsigned long) override {}
+    void dispatchDidLoadResourceFromMemoryCache(const ResourceRequest&, const ResourceResponse&) override {}
 
-    virtual void dispatchDidHandleOnloadEvents() override { }
-    virtual void dispatchDidReceiveServerRedirectForProvisionalLoad() override { }
-    virtual void dispatchWillClose() override { }
-    virtual void dispatchDidStartProvisionalLoad(double triggeringEventTime) override { }
-    virtual void dispatchDidReceiveTitle(const String&) override { }
-    virtual void dispatchDidChangeIcons(IconType) override { }
-    virtual void dispatchDidCommitLoad(HistoryItem*, HistoryCommitType) override { }
-    virtual void dispatchDidFailProvisionalLoad(const ResourceError&, HistoryCommitType) override { }
-    virtual void dispatchDidFailLoad(const ResourceError&, HistoryCommitType) override { }
-    virtual void dispatchDidFinishDocumentLoad() override { }
-    virtual void dispatchDidFinishLoad() override { }
-    virtual void dispatchDidFirstVisuallyNonEmptyLayout() override { }
-    virtual void dispatchDidChangeThemeColor() override { }
+    void dispatchDidHandleOnloadEvents() override {}
+    void dispatchDidReceiveServerRedirectForProvisionalLoad() override {}
+    void dispatchWillClose() override {}
+    void dispatchDidStartProvisionalLoad(double triggeringEventTime) override {}
+    void dispatchDidReceiveTitle(const String&) override {}
+    void dispatchDidChangeIcons(IconType) override {}
+    void dispatchDidCommitLoad(HistoryItem*, HistoryCommitType) override {}
+    void dispatchDidFailProvisionalLoad(const ResourceError&, HistoryCommitType) override {}
+    void dispatchDidFailLoad(const ResourceError&, HistoryCommitType) override {}
+    void dispatchDidFinishDocumentLoad() override {}
+    void dispatchDidFinishLoad() override {}
+    void dispatchDidFirstVisuallyNonEmptyLayout() override {}
+    void dispatchDidChangeThemeColor() override {}
 
-    virtual NavigationPolicy decidePolicyForNavigation(const ResourceRequest&, DocumentLoader*, NavigationPolicy) override;
+    NavigationPolicy decidePolicyForNavigation(const ResourceRequest&, DocumentLoader*, NavigationPolicy) override;
 
-    virtual void dispatchWillSendSubmitEvent(HTMLFormElement*) override;
-    virtual void dispatchWillSubmitForm(HTMLFormElement*) override;
+    void dispatchWillSendSubmitEvent(HTMLFormElement*) override;
+    void dispatchWillSubmitForm(HTMLFormElement*) override;
 
-    virtual void didStartLoading(LoadStartType) override { }
-    virtual void progressEstimateChanged(double) override { }
-    virtual void didStopLoading() override { }
+    void didStartLoading(LoadStartType) override {}
+    void progressEstimateChanged(double) override {}
+    void didStopLoading() override {}
 
-    virtual void loadURLExternally(const ResourceRequest&, NavigationPolicy, const String& = String()) override { }
+    void loadURLExternally(const ResourceRequest&, NavigationPolicy, const String& = String()) override {}
 
-    virtual PassRefPtrWillBeRawPtr<DocumentLoader> createDocumentLoader(LocalFrame*, const ResourceRequest&, const SubstituteData&) override;
+    PassRefPtrWillBeRawPtr<DocumentLoader> createDocumentLoader(LocalFrame*, const ResourceRequest&, const SubstituteData&) override;
 
-    virtual String userAgent(const KURL&) override { return ""; }
+    String userAgent(const KURL&) override { return ""; }
 
-    virtual String doNotTrackValue() override { return String(); }
+    String doNotTrackValue() override { return String(); }
 
-    virtual void transitionToCommittedForNewPage() override { }
+    void transitionToCommittedForNewPage() override {}
 
-    virtual bool navigateBackForward(int offset) const override { return false; }
-    virtual void didDisplayInsecureContent() override { }
-    virtual void didRunInsecureContent(SecurityOrigin*, const KURL&) override { }
-    virtual void didDetectXSS(const KURL&, bool) override { }
-    virtual void didDispatchPingLoader(const KURL&) override { }
-    virtual void selectorMatchChanged(const Vector<String>&, const Vector<String>&) override { }
-    virtual PassRefPtrWillBeRawPtr<LocalFrame> createFrame(const FrameLoadRequest&, const AtomicString&, HTMLFrameOwnerElement*) override;
-    virtual PassOwnPtrWillBeRawPtr<PluginPlaceholder> createPluginPlaceholder(Document&, const KURL&, const Vector<String>& paramNames, const Vector<String>& paramValues, const String& mimeType, bool loadManually) override;
-    virtual PassRefPtrWillBeRawPtr<Widget> createPlugin(HTMLPlugInElement*, const KURL&, const Vector<String>&, const Vector<String>&, const String&, bool, DetachedPluginPolicy) override;
-    virtual bool canCreatePluginWithoutRenderer(const String& mimeType) const override { return false; }
-    virtual PassRefPtrWillBeRawPtr<Widget> createJavaAppletWidget(HTMLAppletElement*, const KURL&, const Vector<String>&, const Vector<String>&) override;
+    bool navigateBackForward(int offset) const override { return false; }
+    void didDisplayInsecureContent() override {}
+    void didRunInsecureContent(SecurityOrigin*, const KURL&) override {}
+    void didDetectXSS(const KURL&, bool) override {}
+    void didDispatchPingLoader(const KURL&) override {}
+    void selectorMatchChanged(const Vector<String>&, const Vector<String>&) override {}
+    PassRefPtrWillBeRawPtr<LocalFrame> createFrame(const FrameLoadRequest&, const AtomicString&, HTMLFrameOwnerElement*) override;
+    PassOwnPtrWillBeRawPtr<PluginPlaceholder> createPluginPlaceholder(Document&, const KURL&, const Vector<String>& paramNames, const Vector<String>& paramValues, const String& mimeType, bool loadManually) override;
+    PassRefPtrWillBeRawPtr<Widget> createPlugin(HTMLPlugInElement*, const KURL&, const Vector<String>&, const Vector<String>&, const String&, bool, DetachedPluginPolicy) override;
+    bool canCreatePluginWithoutRenderer(const String& mimeType) const override { return false; }
+    PassRefPtrWillBeRawPtr<Widget> createJavaAppletWidget(HTMLAppletElement*, const KURL&, const Vector<String>&, const Vector<String>&) override;
 
-    virtual ObjectContentType objectContentType(const KURL&, const String&, bool) override { return ObjectContentType(); }
+    ObjectContentType objectContentType(const KURL&, const String&, bool) override { return ObjectContentType(); }
 
-    virtual void didCreateNewDocument() override { }
-    virtual void dispatchDidClearWindowObjectInMainWorld() override { }
-    virtual void documentElementAvailable() override { }
+    void didCreateNewDocument() override {}
+    void dispatchDidClearWindowObjectInMainWorld() override {}
+    void documentElementAvailable() override {}
 
-    virtual void didCreateScriptContext(v8::Local<v8::Context>, int extensionGroup, int worldId) override { }
-    virtual void willReleaseScriptContext(v8::Local<v8::Context>, int worldId) override { }
-    virtual bool allowScriptExtension(const String& extensionName, int extensionGroup, int worldId) override { return false; }
+    void didCreateScriptContext(v8::Local<v8::Context>, int extensionGroup, int worldId) override {}
+    void willReleaseScriptContext(v8::Local<v8::Context>, int worldId) override {}
+    bool allowScriptExtension(const String& extensionName, int extensionGroup, int worldId) override { return false; }
 
-    virtual v8::Local<v8::Value> createTestInterface(const AtomicString& name) override;
+    v8::Local<v8::Value> createTestInterface(const AtomicString& name) override;
 
-    virtual WebCookieJar* cookieJar() const override { return 0; }
+    WebCookieJar* cookieJar() const override { return 0; }
 
-    virtual void didRequestAutocomplete(HTMLFormElement*) override;
+    void didRequestAutocomplete(HTMLFormElement*) override;
 
-    virtual PassOwnPtr<WebServiceWorkerProvider> createServiceWorkerProvider() override;
-    virtual bool isControlledByServiceWorker(DocumentLoader&) override { return false; }
-    virtual int64_t serviceWorkerID(DocumentLoader&) override { return -1; }
-    virtual PassOwnPtr<WebApplicationCacheHost> createApplicationCacheHost(WebApplicationCacheHostClient*) override;
+    PassOwnPtr<WebServiceWorkerProvider> createServiceWorkerProvider() override;
+    bool isControlledByServiceWorker(DocumentLoader&) override { return false; }
+    int64_t serviceWorkerID(DocumentLoader&) override { return -1; }
+    PassOwnPtr<WebApplicationCacheHost> createApplicationCacheHost(WebApplicationCacheHostClient*) override;
 };
 
 class CORE_EXPORT EmptyTextCheckerClient : public TextCheckerClient {
 public:
     ~EmptyTextCheckerClient() { }
 
-    virtual bool shouldEraseMarkersAfterChangeSelection(TextCheckingType) const override { return true; }
-    virtual void checkSpellingOfString(const String&, int*, int*) override { }
-    virtual String getAutoCorrectSuggestionForMisspelledWord(const String&) override { return String(); }
-    virtual void checkGrammarOfString(const String&, Vector<GrammarDetail>&, int*, int*) override { }
-    virtual void requestCheckingOfString(PassRefPtrWillBeRawPtr<TextCheckingRequest>) override;
+    bool shouldEraseMarkersAfterChangeSelection(TextCheckingType) const override { return true; }
+    void checkSpellingOfString(const String&, int*, int*) override {}
+    String getAutoCorrectSuggestionForMisspelledWord(const String&) override { return String(); }
+    void checkGrammarOfString(const String&, Vector<GrammarDetail>&, int*, int*) override {}
+    void requestCheckingOfString(PassRefPtrWillBeRawPtr<TextCheckingRequest>) override;
 };
 
 class EmptySpellCheckerClient : public SpellCheckerClient {
     WTF_MAKE_NONCOPYABLE(EmptySpellCheckerClient); WTF_MAKE_FAST_ALLOCATED(EmptySpellCheckerClient);
 public:
-    EmptySpellCheckerClient() { }
-    virtual ~EmptySpellCheckerClient() { }
+    EmptySpellCheckerClient() {}
+    ~EmptySpellCheckerClient() override {}
 
-    virtual bool isContinuousSpellCheckingEnabled() override { return false; }
-    virtual void toggleContinuousSpellChecking() override { }
-    virtual bool isGrammarCheckingEnabled() override { return false; }
+    bool isContinuousSpellCheckingEnabled() override { return false; }
+    void toggleContinuousSpellChecking() override {}
+    bool isGrammarCheckingEnabled() override { return false; }
 
-    virtual TextCheckerClient& textChecker() override { return m_textCheckerClient; }
+    TextCheckerClient& textChecker() override { return m_textCheckerClient; }
 
-    virtual void updateSpellingUIWithMisspelledWord(const String&) override { }
-    virtual void showSpellingUI(bool) override { }
-    virtual bool spellingUIIsShowing() override { return false; }
+    void updateSpellingUIWithMisspelledWord(const String&) override {}
+    void showSpellingUI(bool) override {}
+    bool spellingUIIsShowing() override { return false; }
 
 private:
     EmptyTextCheckerClient m_textCheckerClient;
@@ -290,34 +290,34 @@ private:
 class EmptyEditorClient final : public EditorClient {
     WTF_MAKE_NONCOPYABLE(EmptyEditorClient); WTF_MAKE_FAST_ALLOCATED(EmptyEditorClient);
 public:
-    EmptyEditorClient() { }
-    virtual ~EmptyEditorClient() { }
+    EmptyEditorClient() {}
+    ~EmptyEditorClient() override {}
 
-    virtual void respondToChangedContents() override { }
-    virtual void respondToChangedSelection(LocalFrame*, SelectionType) override { }
+    void respondToChangedContents() override {}
+    void respondToChangedSelection(LocalFrame*, SelectionType) override {}
 
-    virtual bool canCopyCut(LocalFrame*, bool defaultValue) const override { return defaultValue; }
-    virtual bool canPaste(LocalFrame*, bool defaultValue) const override { return defaultValue; }
+    bool canCopyCut(LocalFrame*, bool defaultValue) const override { return defaultValue; }
+    bool canPaste(LocalFrame*, bool defaultValue) const override { return defaultValue; }
 
-    virtual bool handleKeyboardEvent() override { return false; }
+    bool handleKeyboardEvent() override { return false; }
 };
 
 class EmptyContextMenuClient final : public ContextMenuClient {
     WTF_MAKE_NONCOPYABLE(EmptyContextMenuClient); WTF_MAKE_FAST_ALLOCATED(EmptyContextMenuClient);
 public:
-    EmptyContextMenuClient() { }
-    virtual ~EmptyContextMenuClient() { }
-    virtual void showContextMenu(const ContextMenu*) override { }
-    virtual void clearContextMenu() override { }
+    EmptyContextMenuClient() {}
+    ~EmptyContextMenuClient() override {}
+    void showContextMenu(const ContextMenu*) override {}
+    void clearContextMenu() override {}
 };
 
 class EmptyDragClient final : public DragClient {
     WTF_MAKE_NONCOPYABLE(EmptyDragClient); WTF_MAKE_FAST_ALLOCATED(EmptyDragClient);
 public:
-    EmptyDragClient() { }
-    virtual ~EmptyDragClient() { }
-    virtual DragDestinationAction actionMaskForDrag(DragData*) override { return DragDestinationActionNone; }
-    virtual void startDrag(DragImage*, const IntPoint&, const IntPoint&, DataTransfer*, LocalFrame*, bool) override { }
+    EmptyDragClient() {}
+    ~EmptyDragClient() override {}
+    DragDestinationAction actionMaskForDrag(DragData*) override { return DragDestinationActionNone; }
+    void startDrag(DragImage*, const IntPoint&, const IntPoint&, DataTransfer*, LocalFrame*, bool) override {}
 };
 
 CORE_EXPORT void fillWithEmptyClients(Page::PageClients&);