Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: Source/core/loader/DocumentLoader.h

Issue 1229743005: Fix virtual/override/final usage in Source/core/{fetch,loader,streams,xmlhttprequest}/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/fetch/XSLStyleSheetResource.h ('k') | Source/core/loader/DocumentThreadableLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/DocumentLoader.h
diff --git a/Source/core/loader/DocumentLoader.h b/Source/core/loader/DocumentLoader.h
index 934724739f83e7daeac4cd884096b11503e94ab1..612588b36fa93e5242623a02562d8a2f47154d8e 100644
--- a/Source/core/loader/DocumentLoader.h
+++ b/Source/core/loader/DocumentLoader.h
@@ -66,7 +66,7 @@ namespace blink {
{
return adoptRefWillBeNoop(new DocumentLoader(frame, request, data));
}
- virtual ~DocumentLoader();
+ ~DocumentLoader() override;
LocalFrame* frame() const { return m_frame; }
@@ -173,11 +173,11 @@ namespace blink {
void finishedLoading(double finishTime);
void mainReceivedError(const ResourceError&);
void cancelLoadAfterXFrameOptionsOrCSPDenied(const ResourceResponse&);
- virtual void redirectReceived(Resource*, ResourceRequest&, const ResourceResponse&) override final;
- virtual void updateRequest(Resource*, const ResourceRequest&) override final;
- virtual void responseReceived(Resource*, const ResourceResponse&, PassOwnPtr<WebDataConsumerHandle>) override final;
- virtual void dataReceived(Resource*, const char* data, unsigned length) override final;
- virtual void notifyFinished(Resource*) override final;
+ void redirectReceived(Resource*, ResourceRequest&, const ResourceResponse&) final;
+ void updateRequest(Resource*, const ResourceRequest&) final;
+ void responseReceived(Resource*, const ResourceResponse&, PassOwnPtr<WebDataConsumerHandle>) final;
+ void dataReceived(Resource*, const char* data, unsigned length) final;
+ void notifyFinished(Resource*) final;
bool maybeLoadEmpty();
« no previous file with comments | « Source/core/fetch/XSLStyleSheetResource.h ('k') | Source/core/loader/DocumentThreadableLoader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698