Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Unified Diff: Source/core/fetch/ScriptResource.h

Issue 1229743005: Fix virtual/override/final usage in Source/core/{fetch,loader,streams,xmlhttprequest}/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/fetch/ResourceLoader.h ('k') | Source/core/fetch/StyleSheetResourceClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/fetch/ScriptResource.h
diff --git a/Source/core/fetch/ScriptResource.h b/Source/core/fetch/ScriptResource.h
index fd42d6810686c17f6a2da800641a5883c699804f..f666b3e385d88fa42bbedd1b4ba42c1e5f1ff066 100644
--- a/Source/core/fetch/ScriptResource.h
+++ b/Source/core/fetch/ScriptResource.h
@@ -37,9 +37,9 @@ class ScriptResource;
class CORE_EXPORT ScriptResourceClient : public ResourceClient {
public:
- virtual ~ScriptResourceClient() { }
+ ~ScriptResourceClient() override {}
static ResourceClientType expectedType() { return ScriptType; }
- virtual ResourceClientType resourceClientType() const override final { return expectedType(); }
+ ResourceClientType resourceClientType() const final { return expectedType(); }
virtual void notifyAppendData(ScriptResource* resource) { }
};
@@ -52,10 +52,10 @@ public:
// Public for testing
ScriptResource(const ResourceRequest&, const String& charset);
- virtual ~ScriptResource();
+ ~ScriptResource() override;
- virtual void didAddClient(ResourceClient*) override;
- virtual void appendData(const char*, unsigned) override;
+ void didAddClient(ResourceClient*) override;
+ void appendData(const char*, unsigned) override;
const String& script();
« no previous file with comments | « Source/core/fetch/ResourceLoader.h ('k') | Source/core/fetch/StyleSheetResourceClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698