Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 1229743005: Fix virtual/override/final usage in Source/core/{fetch,loader,streams,xmlhttprequest}/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2005-2007 Alexey Proskuryakov <ap@webkit.org> 3 * Copyright (C) 2005-2007 Alexey Proskuryakov <ap@webkit.org>
4 * Copyright (C) 2007, 2008 Julien Chaffraix <jchaffraix@webkit.org> 4 * Copyright (C) 2007, 2008 Julien Chaffraix <jchaffraix@webkit.org>
5 * Copyright (C) 2008, 2011 Google Inc. All rights reserved. 5 * Copyright (C) 2008, 2011 Google Inc. All rights reserved.
6 * Copyright (C) 2012 Intel Corporation 6 * Copyright (C) 2012 Intel Corporation
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Lesser General Public 9 * modify it under the terms of the GNU Lesser General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 } // namespace 137 } // namespace
138 138
139 class XMLHttpRequest::BlobLoader final : public GarbageCollectedFinalized<XMLHtt pRequest::BlobLoader>, public FileReaderLoaderClient { 139 class XMLHttpRequest::BlobLoader final : public GarbageCollectedFinalized<XMLHtt pRequest::BlobLoader>, public FileReaderLoaderClient {
140 public: 140 public:
141 static BlobLoader* create(XMLHttpRequest* xhr, PassRefPtr<BlobDataHandle> ha ndle) 141 static BlobLoader* create(XMLHttpRequest* xhr, PassRefPtr<BlobDataHandle> ha ndle)
142 { 142 {
143 return new BlobLoader(xhr, handle); 143 return new BlobLoader(xhr, handle);
144 } 144 }
145 145
146 // FileReaderLoaderClient functions. 146 // FileReaderLoaderClient functions.
147 virtual void didStartLoading() override { } 147 void didStartLoading() override {}
148 virtual void didReceiveDataForClient(const char* data, unsigned length) over ride 148 void didReceiveDataForClient(const char* data, unsigned length) override
149 { 149 {
150 ASSERT(length <= INT_MAX); 150 ASSERT(length <= INT_MAX);
151 m_xhr->didReceiveData(data, length); 151 m_xhr->didReceiveData(data, length);
152 } 152 }
153 virtual void didFinishLoading() override 153 void didFinishLoading() override
154 { 154 {
155 m_xhr->didFinishLoadingFromBlob(); 155 m_xhr->didFinishLoadingFromBlob();
156 } 156 }
157 virtual void didFail(FileError::ErrorCode error) override 157 void didFail(FileError::ErrorCode error) override
158 { 158 {
159 m_xhr->didFailLoadingFromBlob(); 159 m_xhr->didFailLoadingFromBlob();
160 } 160 }
161 161
162 void cancel() 162 void cancel()
163 { 163 {
164 m_loader.cancel(); 164 m_loader.cancel();
165 } 165 }
166 166
167 DEFINE_INLINE_TRACE() 167 DEFINE_INLINE_TRACE()
(...skipping 1497 matching lines...) Expand 10 before | Expand all | Expand 10 after
1665 visitor->trace(m_responseDocumentParser); 1665 visitor->trace(m_responseDocumentParser);
1666 visitor->trace(m_progressEventThrottle); 1666 visitor->trace(m_progressEventThrottle);
1667 visitor->trace(m_upload); 1667 visitor->trace(m_upload);
1668 visitor->trace(m_blobLoader); 1668 visitor->trace(m_blobLoader);
1669 XMLHttpRequestEventTarget::trace(visitor); 1669 XMLHttpRequestEventTarget::trace(visitor);
1670 DocumentParserClient::trace(visitor); 1670 DocumentParserClient::trace(visitor);
1671 ActiveDOMObject::trace(visitor); 1671 ActiveDOMObject::trace(visitor);
1672 } 1672 }
1673 1673
1674 } // namespace blink 1674 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/xmlhttprequest/XMLHttpRequest.h ('k') | Source/core/xmlhttprequest/XMLHttpRequestProgressEvent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698