Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: Source/core/xmlhttprequest/XMLHttpRequest.h

Issue 1229743005: Fix virtual/override/final usage in Source/core/{fetch,loader,streams,xmlhttprequest}/. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/streams/Stream.h ('k') | Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xmlhttprequest/XMLHttpRequest.h
diff --git a/Source/core/xmlhttprequest/XMLHttpRequest.h b/Source/core/xmlhttprequest/XMLHttpRequest.h
index e4c9f194dcd9ec65cefa33340bef8674e36bc9b7..95f8d9ad7bf7fc5d956d0ed6d1e96b9e3cb8ed35 100644
--- a/Source/core/xmlhttprequest/XMLHttpRequest.h
+++ b/Source/core/xmlhttprequest/XMLHttpRequest.h
@@ -79,7 +79,7 @@ class XMLHttpRequest final
public:
static PassRefPtrWillBeRawPtr<XMLHttpRequest> create(ScriptState*);
static PassRefPtrWillBeRawPtr<XMLHttpRequest> create(ExecutionContext*);
- virtual ~XMLHttpRequest();
+ ~XMLHttpRequest() override;
// These exact numeric values are important because JS expects them.
enum State {
@@ -101,15 +101,15 @@ public:
};
// ActiveDOMObject
- virtual void contextDestroyed() override;
- virtual ExecutionContext* executionContext() const override;
- virtual bool hasPendingActivity() const override;
- virtual void suspend() override;
- virtual void resume() override;
- virtual void stop() override;
+ void contextDestroyed() override;
+ ExecutionContext* executionContext() const override;
+ bool hasPendingActivity() const override;
+ void suspend() override;
+ void resume() override;
+ void stop() override;
// XMLHttpRequestEventTarget
- virtual const AtomicString& interfaceName() const override;
+ const AtomicString& interfaceName() const override;
// JavaScript attributes and methods
const KURL& url() const { return m_url; }
@@ -156,15 +156,15 @@ private:
Document* document() const;
SecurityOrigin* securityOrigin() const;
- virtual void didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent) override;
- virtual void didReceiveResponse(unsigned long identifier, const ResourceResponse&, PassOwnPtr<WebDataConsumerHandle>) override;
- virtual void didReceiveData(const char* data, unsigned dataLength) override;
+ void didSendData(unsigned long long bytesSent, unsigned long long totalBytesToBeSent) override;
+ void didReceiveResponse(unsigned long identifier, const ResourceResponse&, PassOwnPtr<WebDataConsumerHandle>) override;
+ void didReceiveData(const char* data, unsigned dataLength) override;
// When responseType is set to "blob", didDownloadData() is called instead
// of didReceiveData().
- virtual void didDownloadData(int dataLength) override;
- virtual void didFinishLoading(unsigned long identifier, double finishTime) override;
- virtual void didFail(const ResourceError&) override;
- virtual void didFailRedirectCheck() override;
+ void didDownloadData(int dataLength) override;
+ void didFinishLoading(unsigned long identifier, double finishTime) override;
+ void didFail(const ResourceError&) override;
+ void didFailRedirectCheck() override;
// BlobLoader notifications.
void didFinishLoadingInternal();
@@ -174,7 +174,7 @@ private:
PassRefPtr<BlobDataHandle> createBlobDataHandleFromResponse();
// DocumentParserClient
- virtual void notifyParserStopped() override;
+ void notifyParserStopped() override;
void endLoading();
« no previous file with comments | « Source/core/streams/Stream.h ('k') | Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698