Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11881055: Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa… (Closed)

Created:
7 years, 11 months ago by jam
Modified:
7 years, 11 months ago
CC:
chromium-reviews, asanka, dbeam+watch-ntp_chromium.org, nkostylev+watch_chromium.org, shishir+watch_chromium.org, achuith+watch_chromium.org, yoshiki+watch_chromium.org, gideonwald, rginda+watch_chromium.org, sail+watch_chromium.org, stevenjb+watch_chromium.org, dominich, melevin, vsevik, benjhayden+dwatch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-options_chromium.org, tbarzic+watch_chromium.org, Randy Smith (Not in Mondays), feature-media-reviews_chromium.org, oshima+watch_chromium.org, pfeldman, Jered, sreeram, yurys, Aaron Boodman, dominich+watch_chromium.org, eroman, David Black, mmenke, samarth+watch_chromium.org, estade+watch_chromium.org, James Su, davemoore+watch_chromium.org, tfarina
Visibility:
Public.

Description

Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interface, and have a URLDataSource interface just for sending the response. Remove the need to have the URLDataSource interface at all, and instead pass a callback to a data source's StartDataRequest method. That also allows us to hide the request_id parameter, which is an internal detail, and makes testing simpler. BUG=169170 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177063

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : fix clang #

Total comments: 17

Patch Set 5 : fix build errors #

Patch Set 6 : fix feedback #

Patch Set 7 : fix issue in about_ui exposed by cros tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+824 lines, -893 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/managed_mode/managed_mode_interstitial.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_source.h View 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_source.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/about_ui.h View 1 2 3 4 5 6 1 chunk +10 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 1 2 3 4 5 6 15 chunks +50 lines, -65 lines 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui.h View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager.h View 6 chunks +24 lines, -31 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager.cc View 1 2 3 4 5 7 chunks +21 lines, -60 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.cc View 6 chunks +21 lines, -18 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_data_source.h View 1 2 chunks +19 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_data_source.cc View 3 chunks +47 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_data_source_unittest.cc View 1 2 3 4 6 chunks +17 lines, -25 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/choose_mobile_network_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/cryptohome_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/diagnostics/diagnostics_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 6 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 5 chunks +15 lines, -14 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc View 4 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/register_page_ui.cc View 4 chunks +13 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/sim_unlock_ui.cc View 5 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/system_info_ui.cc View 1 2 3 4 7 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/conflicts_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/crashes_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/downloads_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_activity_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.h View 5 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 8 chunks +30 lines, -24 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_info_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extensions_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/favicon_source.h View 1 2 3 2 chunks +13 lines, -20 lines 0 comments Download
M chrome/browser/ui/webui/favicon_source.cc View 1 2 3 4 5 8 chunks +29 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/feedback_ui.cc View 1 2 3 4 5 3 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/fileicon_source.h View 1 2 3 3 chunks +17 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/fileicon_source.cc View 1 2 3 5 chunks +20 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/fileicon_source_unittest.cc View 2 chunks +14 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/gesture_config_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/gpu_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/help_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/inspect_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/instant_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/local_omnibox_popup/local_omnibox_popup_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/media/media_internals_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/nacl_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.h View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/thumbnail_source.h View 3 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/ntp/thumbnail_source.cc View 3 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/omnibox/omnibox_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.h View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 5 chunks +14 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/performance_monitor/performance_monitor_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/predictors/predictors_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/profiler_ui.cc View 5 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/quota_internals_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/screenshot_source.h View 4 chunks +24 lines, -20 lines 0 comments Download
M chrome/browser/ui/webui/screenshot_source.cc View 6 chunks +20 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/session_favicon_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/set_as_default_browser_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/shared_resources_data_source.h View 1 chunk +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/shared_resources_data_source.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/signin_internals_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/suggestions_internals/suggestions_internals_ui.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/sync_internals_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/tab_modal_confirm_dialog_webui.cc View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/task_manager/task_manager_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/theme_source.h View 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/theme_source.cc View 6 chunks +14 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/theme_source_unittest.cc View 1 2 3 4 4 chunks +33 lines, -47 lines 0 comments Download
M chrome/browser/ui/webui/tracing_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/user_actions/user_actions_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/version_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_browsertest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/web_ui_util.cc View 2 chunks +40 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/webrtc_internals_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/welcome_ui_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/public/browser/url_data_source.h View 2 chunks +21 lines, -25 lines 1 comment Download
A + content/public/browser/url_data_source.cc View 1 chunk +4 lines, -11 lines 0 comments Download
D content/public/browser/url_data_source_delegate.h View 1 chunk +0 lines, -80 lines 0 comments Download
D content/public/browser/url_data_source_delegate.cc View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jam
7 years, 11 months ago (2013-01-15 19:59:58 UTC) #1
Evan Stade
lgtm https://codereview.chromium.org/11881055/diff/13015/chrome/browser/ui/webui/about_ui.cc File chrome/browser/ui/webui/about_ui.cc (right): https://codereview.chromium.org/11881055/diff/13015/chrome/browser/ui/webui/about_ui.cc#newcode1060 chrome/browser/ui/webui/about_ui.cc:1060: ChromeURLDataManager::AddDataSource(profile, source); combine these lines? https://codereview.chromium.org/11881055/diff/13015/chrome/browser/ui/webui/chrome_url_data_manager.cc File chrome/browser/ui/webui/chrome_url_data_manager.cc ...
7 years, 11 months ago (2013-01-15 20:49:33 UTC) #2
jam
Thanks for the review! https://codereview.chromium.org/11881055/diff/13015/chrome/browser/ui/webui/about_ui.cc File chrome/browser/ui/webui/about_ui.cc (right): https://codereview.chromium.org/11881055/diff/13015/chrome/browser/ui/webui/about_ui.cc#newcode1060 chrome/browser/ui/webui/about_ui.cc:1060: ChromeURLDataManager::AddDataSource(profile, source); On 2013/01/15 20:49:34, ...
7 years, 11 months ago (2013-01-15 21:09:08 UTC) #3
Evan Stade
https://codereview.chromium.org/11881055/diff/13015/chrome/browser/ui/webui/about_ui.cc File chrome/browser/ui/webui/about_ui.cc (right): https://codereview.chromium.org/11881055/diff/13015/chrome/browser/ui/webui/about_ui.cc#newcode1060 chrome/browser/ui/webui/about_ui.cc:1060: ChromeURLDataManager::AddDataSource(profile, source); On 2013/01/15 21:09:08, John Abd-El-Malek wrote: > ...
7 years, 11 months ago (2013-01-15 21:33:42 UTC) #4
jam
https://codereview.chromium.org/11881055/diff/13015/chrome/browser/ui/webui/about_ui.cc File chrome/browser/ui/webui/about_ui.cc (right): https://codereview.chromium.org/11881055/diff/13015/chrome/browser/ui/webui/about_ui.cc#newcode1060 chrome/browser/ui/webui/about_ui.cc:1060: ChromeURLDataManager::AddDataSource(profile, source); On 2013/01/15 21:33:43, Evan Stade wrote: > ...
7 years, 11 months ago (2013-01-15 21:39:47 UTC) #5
tfarina
7 years, 11 months ago (2013-01-16 03:01:51 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/11881055/diff/43009/content/public/browser/ur...
File content/public/browser/url_data_source.h (right):

https://codereview.chromium.org/11881055/diff/43009/content/public/browser/ur...
content/public/browser/url_data_source.h:11: #include "base/callback.h"
sort

Powered by Google App Engine
This is Rietveld 408576698