Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6417)

Unified Diff: chrome/browser/ui/webui/theme_source.h

Issue 11881055: Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix issue in about_ui exposed by cros tests Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/theme_source.h
===================================================================
--- chrome/browser/ui/webui/theme_source.h (revision 176942)
+++ chrome/browser/ui/webui/theme_source.h (working copy)
@@ -9,7 +9,7 @@
#include "base/compiler_specific.h"
#include "base/memory/ref_counted.h"
-#include "content/public/browser/url_data_source_delegate.h"
+#include "content/public/browser/url_data_source.h"
#include "ui/base/layout.h"
class Profile;
@@ -18,28 +18,28 @@
class RefCountedMemory;
}
-class ThemeSource : public content::URLDataSourceDelegate {
+class ThemeSource : public content::URLDataSource {
public:
explicit ThemeSource(Profile* profile);
+ virtual ~ThemeSource();
- // content::URLDataSourceDelegate implementation.
+ // content::URLDataSource implementation.
virtual std::string GetSource() OVERRIDE;
- virtual void StartDataRequest(const std::string& path,
- bool is_incognito,
- int request_id) OVERRIDE;
+ virtual void StartDataRequest(
+ const std::string& path,
+ bool is_incognito,
+ const content::URLDataSource::GotDataCallback& callback) OVERRIDE;
virtual std::string GetMimeType(const std::string& path) const OVERRIDE;
virtual MessageLoop* MessageLoopForRequestPath(
const std::string& path) const OVERRIDE;
virtual bool ShouldReplaceExistingSource() const OVERRIDE;
- protected:
- virtual ~ThemeSource();
-
private:
// Fetch and send the theme bitmap.
- void SendThemeBitmap(int request_id,
- int resource_id,
- ui::ScaleFactor scale_factor);
+ void SendThemeBitmap(
+ const content::URLDataSource::GotDataCallback& callback,
+ int resource_id,
+ ui::ScaleFactor scale_factor);
// The original profile (never an OTR profile).
Profile* profile_;

Powered by Google App Engine
This is Rietveld 408576698