Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/browser/ui/webui/extensions/extension_info_ui.cc

Issue 11881055: Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix issue in about_ui exposed by cros tests Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/extensions/extension_info_ui.h" 5 #include "chrome/browser/ui/webui/extensions/extension_info_ui.h"
6 6
7 #include "base/i18n/time_formatting.h" 7 #include "base/i18n/time_formatting.h"
8 #include "base/stringprintf.h" 8 #include "base/stringprintf.h"
9 #include "base/time.h" 9 #include "base/time.h"
10 #include "base/utf_string_conversions.h" 10 #include "base/utf_string_conversions.h"
(...skipping 21 matching lines...) Expand all
32 source_->AddLocalizedString("lastUpdated", 32 source_->AddLocalizedString("lastUpdated",
33 IDS_EXTENSION_SCRIPT_POPUP_LAST_UPDATED); 33 IDS_EXTENSION_SCRIPT_POPUP_LAST_UPDATED);
34 source_->set_use_json_js_format_v2(); 34 source_->set_use_json_js_format_v2();
35 source_->set_json_path("strings.js"); 35 source_->set_json_path("strings.js");
36 36
37 source_->add_resource_path("extension_info.css", IDR_EXTENSION_INFO_CSS); 37 source_->add_resource_path("extension_info.css", IDR_EXTENSION_INFO_CSS);
38 source_->add_resource_path("extension_info.js", IDR_EXTENSION_INFO_JS); 38 source_->add_resource_path("extension_info.js", IDR_EXTENSION_INFO_JS);
39 source_->set_default_resource(IDR_EXTENSION_INFO_HTML); 39 source_->set_default_resource(IDR_EXTENSION_INFO_HTML);
40 40
41 Profile* profile = Profile::FromWebUI(web_ui); 41 Profile* profile = Profile::FromWebUI(web_ui);
42 ChromeURLDataManager::AddDataSource(profile, source_); 42 ChromeURLDataManager::AddDataSourceImpl(profile, source_);
43 } 43 }
44 44
45 ExtensionInfoUI::~ExtensionInfoUI() { 45 ExtensionInfoUI::~ExtensionInfoUI() {
46 } 46 }
47 47
48 // static 48 // static
49 GURL ExtensionInfoUI::GetURL(const std::string& extension_id) { 49 GURL ExtensionInfoUI::GetURL(const std::string& extension_id) {
50 return GURL(base::StringPrintf( 50 return GURL(base::StringPrintf(
51 "%s%s", chrome::kChromeUIExtensionInfoURL, extension_id.c_str())); 51 "%s%s", chrome::kChromeUIExtensionInfoURL, extension_id.c_str()));
52 } 52 }
(...skipping 14 matching lines...) Expand all
67 ExtensionIconSource::GetIconURL(extension, 67 ExtensionIconSource::GetIconURL(extension,
68 extension_misc::EXTENSION_ICON_MEDIUM, 68 extension_misc::EXTENSION_ICON_MEDIUM,
69 ExtensionIconSet::MATCH_BIGGER, 69 ExtensionIconSet::MATCH_BIGGER,
70 false, NULL); 70 false, NULL);
71 source_->AddString("icon", UTF8ToUTF16(icon.spec())); 71 source_->AddString("icon", UTF8ToUTF16(icon.spec()));
72 // Set the last update time (the install time). 72 // Set the last update time (the install time).
73 base::Time install_time = extension_service->extension_prefs()-> 73 base::Time install_time = extension_service->extension_prefs()->
74 GetInstallTime(extension_id); 74 GetInstallTime(extension_id);
75 source_->AddString("installTime", base::TimeFormatShortDate(install_time)); 75 source_->AddString("installTime", base::TimeFormatShortDate(install_time));
76 } 76 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698