chrome/browser/ui/webui/bookmarks_ui.cc - Issue 11881055: Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/bookmarks_ui.cc

Issue 11881055: Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix issue in about_ui exposed by cros tests Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/bookmarks_ui.h ('k') | chrome/browser/ui/webui/certificate_viewer_ui.cc » ('j') | content/public/browser/url_data_source.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/bookmarks_ui.cc

===================================================================

--- chrome/browser/ui/webui/bookmarks_ui.cc (revision 176942)

+++ chrome/browser/ui/webui/bookmarks_ui.cc (working copy)

@@ -7,7 +7,6 @@

#include "base/memory/ref_counted_memory.h"

#include "base/message_loop.h"

#include "chrome/browser/profiles/profile.h"

-#include "chrome/browser/ui/webui/chrome_url_data_manager.h"

#include "chrome/common/url_constants.h"

#include "content/public/browser/web_ui.h"

#include "grit/theme_resources.h"

@@ -26,13 +25,14 @@

return chrome::kChromeUIBookmarksHost;

}

-void BookmarksUIHTMLSource::StartDataRequest(const std::string& path,

- bool is_incognito,

- int request_id) {

+void BookmarksUIHTMLSource::StartDataRequest(

+ const std::string& path,

+ bool is_incognito,

+ const content::URLDataSource::GotDataCallback& callback) {

NOTREACHED() << "We should never get here since the extension should have"

<< "been triggered";

- url_data_source()->SendResponse(request_id, NULL);

+ callback.Run(NULL);

}

std::string BookmarksUIHTMLSource::GetMimeType(const std::string& path) const {

« no previous file with comments | « chrome/browser/ui/webui/bookmarks_ui.h ('k') | chrome/browser/ui/webui/certificate_viewer_ui.cc » ('j') | content/public/browser/url_data_source.h » ('J')