Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5851)

Unified Diff: chrome/browser/ui/webui/options/chromeos/user_image_source.cc

Issue 11881055: Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix issue in about_ui exposed by cros tests Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/chromeos/user_image_source.cc
===================================================================
--- chrome/browser/ui/webui/options/chromeos/user_image_source.cc (revision 176942)
+++ chrome/browser/ui/webui/options/chromeos/user_image_source.cc (working copy)
@@ -9,7 +9,6 @@
#include "base/string_split.h"
#include "chrome/browser/chromeos/login/default_user_images.h"
#include "chrome/browser/chromeos/login/user_manager.h"
-#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
#include "chrome/browser/ui/webui/web_ui_util.h"
#include "chrome/common/url_constants.h"
#include "googleurl/src/url_parse.h"
@@ -86,17 +85,16 @@
return chrome::kChromeUIUserImageHost;
}
-void UserImageSource::StartDataRequest(const std::string& path,
- bool is_incognito,
- int request_id) {
+void UserImageSource::StartDataRequest(
+ const std::string& path,
+ bool is_incognito,
+ const content::URLDataSource::GotDataCallback& callback) {
std::string email;
bool is_image_animated = false;
ui::ScaleFactor scale_factor;
GURL url(chrome::kChromeUIUserImageURL + path);
ParseRequest(url, &email, &is_image_animated, &scale_factor);
- url_data_source()->SendResponse(
- request_id,
- GetUserImage(email, is_image_animated, scale_factor));
+ callback.Run(GetUserImage(email, is_image_animated, scale_factor));
}
std::string UserImageSource::GetMimeType(const std::string& path) const {

Powered by Google App Engine
This is Rietveld 408576698