Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa…

chrome/browser/ui/webui/help/help_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/help/help_ui.h"
 
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/webui/help/help_handler.h"
 #include "chrome/browser/ui/webui/chrome_url_data_manager.h"
 #include "chrome/browser/ui/webui/chrome_web_ui_data_source.h"
@@ skipping 15 matching lines @@
   source->set_default_resource(IDR_HELP_HTML);
   return source;
 }
 
 }  // namespace
 
 HelpUI::HelpUI(content::WebUI* web_ui)
     : WebUIController(web_ui) {
   Profile* profile = Profile::FromWebUI(web_ui);
   ChromeWebUIDataSource* source = CreateAboutPageHTMLSource();
-  ChromeURLDataManager::AddDataSource(profile, source);
+  ChromeURLDataManager::AddDataSourceImpl(profile, source);
   ChromeURLDataManager::AddDataSource(profile, new SharedResourcesDataSource());
 
   HelpHandler* handler = new HelpHandler();
   handler->GetLocalizedValues(source->localized_strings());

[Evan Stade, 2013/01/15 20:49:34]

nit: this should probably come before AddDataSourceImpl (at least that's the
pattern that's used everywhere else)

[jam, 2013/01/15 21:09:08]

not sure what you mean, AddDataSourceImpl isn't called on HelpHandler?

[Evan Stade, 2013/01/15 21:33:43]

I meant reversing the order of the two blocks, but since you want to minimize
changes you can just leave it alone.

   web_ui->AddMessageHandler(handler);
 }
 
 HelpUI::~HelpUI() {
 }