Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa…

chrome/browser/ui/webui/screenshot_source.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/screenshot_source.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/i18n/time_formatting.h"
 #include "base/memory/ref_counted_memory.h"
 #include "base/message_loop.h"
 #include "base/path_service.h"
 #include "base/string16.h"
 #include "base/stringprintf.h"
 #include "base/string_util.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
-#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "googleurl/src/url_canon.h"
 #include "googleurl/src/url_util.h"
 
 #if defined(USE_ASH)
 #include "ash/shell.h"
 #include "ash/shell_delegate.h"
 #endif
@@ skipping 103 matching lines @@
   }
   return true;
 }
 
 #endif
 
 std::string ScreenshotSource::GetSource() {
   return chrome::kChromeUIScreenshotPath;
 }
 
-void ScreenshotSource::StartDataRequest(const std::string& path, bool,
-                                        int request_id) {
-  SendScreenshot(path, request_id);
+void ScreenshotSource::StartDataRequest(
+  const std::string& path,
+  bool is_incognito,
+  const content::URLDataSource::GotDataCallback& callback) {
+  SendScreenshot(path, callback);
 }
 
 std::string ScreenshotSource::GetMimeType(const std::string&) const {
   // We need to explicitly return a mime type, otherwise if the user tries to
   // drag the image they get no extension.
   return "image/png";
 }
 
 ScreenshotDataPtr ScreenshotSource::GetCachedScreenshot(
     const std::string& screenshot_path) {
   std::map<std::string, ScreenshotDataPtr>::iterator pos;
   std::string path = screenshot_path.substr(
       0, screenshot_path.find_first_of("?"));
   if ((pos = cached_screenshots_.find(path)) != cached_screenshots_.end()) {
     return pos->second;
   } else {
     return ScreenshotDataPtr(new ScreenshotData);
   }
 }
 
-void ScreenshotSource::SendScreenshot(const std::string& screenshot_path,
-                                      int request_id) {
+void ScreenshotSource::SendScreenshot(
+    const std::string& screenshot_path,
+    const content::URLDataSource::GotDataCallback& callback) {
   // Strip the query param value - we only use it as a hack to ensure our
   // image gets reloaded instead of being pulled from the browser cache
   std::string path = screenshot_path.substr(
       0, screenshot_path.find_first_of("?"));
   if (path == ScreenshotSource::kScreenshotCurrent) {
-    CacheAndSendScreenshot(path, request_id, current_screenshot_);
+    CacheAndSendScreenshot(path, callback, current_screenshot_);
 #if defined(OS_CHROMEOS)
   } else if (path.compare(0, strlen(ScreenshotSource::kScreenshotSaved),
              ScreenshotSource::kScreenshotSaved) == 0) {
     using content::BrowserThread;
 
     std::string filename =
                        path.substr(strlen(ScreenshotSource::kScreenshotSaved));
 
     url_canon::RawCanonOutputT<char16> decoded;
     url_util::DecodeURLEscapeSequences(
         filename.data(), filename.size(), &decoded);
     // Screenshot filenames don't use non-ascii characters.
     std::string decoded_filename = UTF16ToASCII(string16(
         decoded.data(), decoded.length()));
 
     FilePath download_path;
     GetScreenshotDirectory(&download_path);
     if (drive::util::IsUnderDriveMountPoint(download_path)) {
       drive::DriveFileSystemInterface* file_system =
           drive::DriveSystemServiceFactory::GetForProfile(
               profile_)->file_system();
       file_system->GetFileByResourceId(
           decoded_filename,
           base::Bind(&ScreenshotSource::GetSavedScreenshotCallback,
-                     base::Unretained(this), screenshot_path, request_id),
+                     base::Unretained(this), screenshot_path, callback),
           google_apis::GetContentCallback());
     } else {
       BrowserThread::PostTask(
           BrowserThread::FILE, FROM_HERE,
           base::Bind(&ScreenshotSource::SendSavedScreenshot,
                      base::Unretained(this),
                      screenshot_path,
-                     request_id, download_path.Append(decoded_filename)));
+                     callback, download_path.Append(decoded_filename)));
     }
 #endif
   } else {
     CacheAndSendScreenshot(
-        path, request_id, ScreenshotDataPtr(new ScreenshotData()));
+        path, callback, ScreenshotDataPtr(new ScreenshotData()));
   }
 }
 
 #if defined(OS_CHROMEOS)
 void ScreenshotSource::SendSavedScreenshot(
     const std::string& screenshot_path,
-    int request_id,
+    const content::URLDataSource::GotDataCallback& callback,
     const FilePath& file) {
   ScreenshotDataPtr read_bytes(new ScreenshotData);
   int64 file_size = 0;
 
   if (!file_util::GetFileSize(file, &file_size)) {
-    CacheAndSendScreenshot(screenshot_path, request_id, read_bytes);
+    CacheAndSendScreenshot(screenshot_path, callback, read_bytes);
     return;
   }
 
   read_bytes->resize(file_size);
   if (!file_util::ReadFile(file, reinterpret_cast<char*>(&read_bytes->front()),
                            static_cast<int>(file_size)))
     read_bytes->clear();
 
-  CacheAndSendScreenshot(screenshot_path, request_id, read_bytes);
+  CacheAndSendScreenshot(screenshot_path, callback, read_bytes);
 }
 
 void ScreenshotSource::GetSavedScreenshotCallback(
     const std::string& screenshot_path,
-    int request_id,
+    const content::URLDataSource::GotDataCallback& callback,
     drive::DriveFileError error,
     const FilePath& file,
     const std::string& unused_mime_type,
     drive::DriveFileType file_type) {
   if (error != drive::DRIVE_FILE_OK || file_type != drive::REGULAR_FILE) {
     ScreenshotDataPtr read_bytes(new ScreenshotData);
-    CacheAndSendScreenshot(screenshot_path, request_id, read_bytes);
+    CacheAndSendScreenshot(screenshot_path, callback, read_bytes);
     return;
   }
 
   content::BrowserThread::PostTask(
       content::BrowserThread::FILE, FROM_HERE,
       base::Bind(&ScreenshotSource::SendSavedScreenshot,
-                 base::Unretained(this), screenshot_path, request_id, file));
+                 base::Unretained(this), screenshot_path, callback, file));
 }
 #endif
 
 void ScreenshotSource::CacheAndSendScreenshot(
     const std::string& screenshot_path,
-    int request_id,
+    const content::URLDataSource::GotDataCallback& callback,
     ScreenshotDataPtr bytes) {
   // Strip the query from the screenshot path.
   std::string path = screenshot_path.substr(
       0, screenshot_path.find_first_of("?"));
   cached_screenshots_[path] = bytes;
-  url_data_source()->SendResponse(
-      request_id, new base::RefCountedBytes(*bytes));
+  callback.Run(new base::RefCountedBytes(*bytes));
 }