Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

Issue 11881055: Simplify WebUI data sources. Currently WebUI data sources implement a URLDataSourceDelegate interfa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix issue in about_ui exposed by cros tests Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/bookmark_manager_private/bookmark_manage r_private_api.h" 5 #include "chrome/browser/extensions/api/bookmark_manager_private/bookmark_manage r_private_api.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/json/json_writer.h" 9 #include "base/json/json_writer.h"
10 #include "base/prefs/public/pref_service_base.h" 10 #include "base/prefs/public/pref_service_base.h"
11 #include "base/string_number_conversions.h" 11 #include "base/string_number_conversions.h"
12 #include "base/values.h" 12 #include "base/values.h"
13 #include "chrome/browser/bookmarks/bookmark_model.h" 13 #include "chrome/browser/bookmarks/bookmark_model.h"
14 #include "chrome/browser/bookmarks/bookmark_model_factory.h" 14 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
15 #include "chrome/browser/bookmarks/bookmark_node_data.h" 15 #include "chrome/browser/bookmarks/bookmark_node_data.h"
16 #include "chrome/browser/bookmarks/bookmark_utils.h" 16 #include "chrome/browser/bookmarks/bookmark_utils.h"
17 #include "chrome/browser/extensions/api/bookmark_manager_private/bookmark_manage r_private_api_constants.h" 17 #include "chrome/browser/extensions/api/bookmark_manager_private/bookmark_manage r_private_api_constants.h"
18 #include "chrome/browser/extensions/api/bookmarks/bookmark_api_constants.h" 18 #include "chrome/browser/extensions/api/bookmarks/bookmark_api_constants.h"
19 #include "chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h" 19 #include "chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.h"
20 #include "chrome/browser/extensions/event_router.h" 20 #include "chrome/browser/extensions/event_router.h"
21 #include "chrome/browser/extensions/extension_function_dispatcher.h" 21 #include "chrome/browser/extensions/extension_function_dispatcher.h"
22 #include "chrome/browser/extensions/extension_system.h" 22 #include "chrome/browser/extensions/extension_system.h"
23 #include "chrome/browser/extensions/extension_web_ui.h" 23 #include "chrome/browser/extensions/extension_web_ui.h"
24 #include "chrome/browser/profiles/profile.h" 24 #include "chrome/browser/profiles/profile.h"
25 #include "chrome/browser/ui/webui/chrome_url_data_manager.h" 25 #include "chrome/browser/ui/webui/web_ui_util.h"
26 #include "chrome/browser/view_type_utils.h" 26 #include "chrome/browser/view_type_utils.h"
27 #include "chrome/common/pref_names.h" 27 #include "chrome/common/pref_names.h"
28 #include "content/public/browser/render_view_host.h" 28 #include "content/public/browser/render_view_host.h"
29 #include "content/public/browser/web_contents.h" 29 #include "content/public/browser/web_contents.h"
30 #include "content/public/browser/web_ui.h" 30 #include "content/public/browser/web_ui.h"
31 #include "grit/generated_resources.h" 31 #include "grit/generated_resources.h"
32 #include "ui/base/l10n/l10n_util.h" 32 #include "ui/base/l10n/l10n_util.h"
33 33
34 #if defined(OS_WIN) 34 #if defined(OS_WIN)
35 #include "win8/util/win8_util.h" 35 #include "win8/util/win8_util.h"
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 l10n_util::GetStringUTF16(IDS_BOOKMARK_MANAGER_RECENT)); 371 l10n_util::GetStringUTF16(IDS_BOOKMARK_MANAGER_RECENT));
372 localized_strings->SetString("search", 372 localized_strings->SetString("search",
373 l10n_util::GetStringUTF16(IDS_BOOKMARK_MANAGER_SEARCH)); 373 l10n_util::GetStringUTF16(IDS_BOOKMARK_MANAGER_SEARCH));
374 localized_strings->SetString("bookmark_all_tabs", 374 localized_strings->SetString("bookmark_all_tabs",
375 l10n_util::GetStringUTF16(IDS_BOOKMARK_MANAGER_BOOKMARK_ALL_TABS)); 375 l10n_util::GetStringUTF16(IDS_BOOKMARK_MANAGER_BOOKMARK_ALL_TABS));
376 localized_strings->SetString("save", 376 localized_strings->SetString("save",
377 l10n_util::GetStringUTF16(IDS_SAVE)); 377 l10n_util::GetStringUTF16(IDS_SAVE));
378 localized_strings->SetString("cancel", 378 localized_strings->SetString("cancel",
379 l10n_util::GetStringUTF16(IDS_CANCEL)); 379 l10n_util::GetStringUTF16(IDS_CANCEL));
380 380
381 URLDataSource::SetFontAndTextDirection(localized_strings); 381 web_ui_util::SetFontAndTextDirection(localized_strings);
382 382
383 SetResult(localized_strings); 383 SetResult(localized_strings);
384 384
385 // This is needed because unlike the rest of these functions, this class 385 // This is needed because unlike the rest of these functions, this class
386 // inherits from AsyncFunction directly, rather than BookmarkFunction. 386 // inherits from AsyncFunction directly, rather than BookmarkFunction.
387 SendResponse(true); 387 SendResponse(true);
388 388
389 return true; 389 return true;
390 } 390 }
391 391
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
518 #if defined(OS_WIN) 518 #if defined(OS_WIN)
519 if (win8::IsSingleWindowMetroMode()) 519 if (win8::IsSingleWindowMetroMode())
520 can_open_new_windows = false; 520 can_open_new_windows = false;
521 #endif // OS_WIN 521 #endif // OS_WIN
522 522
523 SetResult(new base::FundamentalValue(can_open_new_windows)); 523 SetResult(new base::FundamentalValue(can_open_new_windows));
524 return true; 524 return true;
525 } 525 }
526 526
527 } // namespace extensions 527 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698